8000 Add-on not working on Firefox · Issue #69 · jplattel/obsidian-clipper · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Add-on not working on Firefox #69

Open
kmf opened this issue Jan 17, 2023 · 3 comments
Open

Add-on not working on Firefox #69

kmf opened this issue Jan 17, 2023 · 3 comments
Assignees
@jplattel
Labels
bug Something isn't working

Comments

@kmf
Copy link
kmf commented Jan 17, 2023

image

Tested on Firefox 109.0

Old Version (0.3.6): https://addons.mozilla.org/en-US/firefox/addon/obsidian-clipper/
@kmf kmf added the bug Something isn't working label Jan 17, 2023
This was referenced Jan 17, 2023
Open
Open
@ondrahlavac
Copy link
ondrahlavac commented Aug 4, 2023 •
edited
Loading

Not sure about @jplattel's plans, but to me it feels like chrome/firefox compatibility is not comming back anytime soon.

EDIT: I am an amateur .... that's all. 😄

I'm trying to hack my version locally at the monent.
Will report on my results. 😆

@ondrahlavac
Copy link
ondrahlavac commented Aug 5, 2023 •
edited
Loading

Ok, so I'm back with the news.

There has been an issue with new version of manifest. Google pushed for the quick adoption of Manifest V3 and Firefox has not finalized their implementation.

Nevertheless, two things need to change for this to work with Firefox.

  1. manifest.json for the firefox build needs to keep the following definiton, as it was in Manifest V2:
    "background": { "scripts": ["background.js"], "type": "module" },
  2. Since the new chrome.storage.sync is being used, firefox needs Add-on ID to be added to manifest.json.
    "browser_specific_settings": { "gecko": { "id": "firefox-obsidian-clipper-addon@example.com" } }

References:

Next steps

Normally, I would send a pull request, but this is something for Joost (@jplattel) to decide.
Basically you need to build with two different manifests for firefox and chrome.

I got my version running as unsigned addon - https://github.com/ondrahlavac/obsidian-clipper/tree/personal-version
But it's just a hack, not a fix.

So... @jplattel, can I somehow be of service so we can get this fixed? :-)

@ondrahlavac
Copy link

@kmf @mcheck
You can use my hacked version - obsidian_clipper_for_firefox-0.5.x.zip
https://github.com/ondrahlavac/obsidian-clipper/tree/personal-version/

Just to carry us over before we find a way to get it all sorted and get a fresh new version to addons.mozilla.org

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jplattel jplattel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kmf @ondrahlavac @jplattel
0