8000 Not being able to send a message with a # followed by 101 characters is dubious · Issue #291 · jocosocial/twitarr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Not being able to send a message with a # followed by 101 characters is dubious #291

Open
Hixie opened this issue Jan 15, 2020 · 1 comment
Open

Not being able to send a message with a # followed by 101 characters is dubious #291

Hixie opened this issue Jan 15, 2020 · 1 comment
Labels
discussion A topic of discussion which may lead to enhancements or other changes

Comments

@Hixie
Copy link
Hixie commented Jan 15, 2020

Having long hashtags not be allowed to be sent (rather than just having the server ignore them) is the wrong choice, I think. It has a number of disadvantages:

  1. It's an error condition the client can't preclude, because there's no way to prevent the user from entering bad data (exactly what will trigger this error isn't 100% well defined, for one).
  2. Because of (1), it means a bunch of extra error-handling logic has to be added to the client to handle this case which otherwise would not be needed (because in all other cases, an error from the server means a bug or a server load issue, not user error).
  3. It's doesn't really matter if the hashtag is just truncated or otherwise mangled when indexed on the server, what really matters is just that the text shows.
  4. It's hard to explain to someone who doesn't know what a Hashtag is.
  5. It will cause issues if there's valid reasons to include a string like #foo.

I think we should make the server not throw this error and instead just ignore the hashtag if it's too long.

cc @hendricksond
@hendricksond
Copy link
Member

I took one pass at this. It's easy to make the server ignore the over-length hashtag when parsing the post, so that no Hashtag record is created and associated to the post. However, it is not easy to make the call to auto_link that is used when sending the text to the client ignore the long hashtag. So, the link will still be present in the web client. Going to leave this open and try to think of a solution for that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion A topic of discussion which may lead to enhancements or other changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hixie @hendricksond
0