8000 GitHub · Where software is built
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Dont send responses for some control messages #2930
Closed
@jacobowitz

Description

@jacobowitz

At the moment we are sending response to all control and data requests, which is done in the msg_callback in the ZEDRuntime:
https://github.com/jina-ai/jina/blob/master/jina/peapods/runtimes/zmq/zed.py#L303

For some control requests this is wrong and potentially dangerous (at least IDLE/CLOSE) as the other side of the communication may never expect a response and could already be dead by the time we try to respond. This is one of the reasons for hanging CI at the moment when a head pea tries to respond to IDLE requests of its already closed peas.

We should write a test to capture the cases where we accept and dont accept responses to control requests.

Discovered with @JoanFM

Metadata

Metadata

Assignees

Labels

area/coreThis issue/PR affects the core codebase

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0