Marked plugin as thread safe #213
Conversation
…rked JFlexMojo as thread-safe. Closes #211
|
This looks great, thanks Daniel! But as Gerwin mentioned over on #211, there are known non-thread-safe things that need to be dealt with, e.g. converting static options to instance members, before we can declare the plugin thread-safe. |
|
Is it possible to add at least the annotations and mark the plugin as non thread-safe until the conversion will be done? I think, the annotations are a useful improvement in general.
|
|
I think the annotations are a good idea, happy to have them, if we mark it as non thread-safe for now. @sarowe do you agree? |
+1 |
|
Nice!!! Thank you!
|
|
Now merged and marked as not thread safe (for now) as discussed in 104b219 Thanks for the contribution! |
| @@ -44,7 +44,7 @@ | |||
| <url>https://github.com/jflex-de/jflex/issues</url> | |||
| </issueManagement> | |||
| <pre 8000 requisites> | |||
| <maven>3.0.1</maven> | |||
| <maven>${maven.version}</maven> | |||
There was a problem hiding this comment.
We need a very recent version of Maven to compile JFlex due to a bug in maven-shade-plugin.
Are you sure we actually need the same to execute the plugin? It sounds to me that 3.0 should be enough.
There was a problem hiding this comment.
Maven version 3 should really be enough. The annotation were introduced back then.
|
Thanks for updating the plugin to use Java annotations rather than invalid javadoc tags. |
|
You are welcome! |
Updated to maven-plugin-api 3.0.5 and introduced Mojo annotations. Marked JFlexMojo as thread-safe. Closes #211