8000 Comparing pahans:master...jchristman:master · pahans/reactive-modal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pahans/reactive-modal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jchristman/reactive-modal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 5 files changed
  • 4 contributors

Commits on Feb 26, 2015

  1. - Fixed javascript closure issue on convenience functions 

    - Added reactivity on button labels and closeModalOnClick
- Added more convenience functions: .closeOnClick(), .noCloseOnClick(),
  .setLabel('XXXXX')
    @jchristman
    jchristman committed Feb 26, 2015
    Configuration menu
    Copy the full SHA
    138c892 View commit details
    Browse the repository at this point in the history

  2. - Removed unnecessary console.logs

    @jchristman
    jchristman committed Feb 26, 2015
    Configuration menu
    Copy the full SHA
    339d2e4 View commit details
    Browse the repository at this point in the history

  3. - bug fix

    @jchristman
    jchristman committed Feb 26, 2015
    Configuration menu
    Copy the full SHA
    70b2a1c View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2015

  1. - changed to be create own atmosphere repository

    @jchristman
    jchristman 8000 committed Apr 16, 2015
    Configuration menu
    Copy the full SHA
    cb79fc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2015

  1. adds icon support for buttons 

    Change-Id: I84f78b76fb64cef1072c98e6bba8b83c217fa88f
    Christian Fehmer committed Jul 4, 2015
    Configuration menu
    Copy the full SHA
    c356219 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2015

  1. Merge pull request #1 from fehmer/master 

    adds icon support for buttons
    @jchristman
    jchristman committed Jul 5, 2015
    Configuration menu
    Copy the full SHA
    8ce2f7a View commit details
    Browse the repository at this point in the history

  2. - Version bump

    @jchristman
    jchristman committed Jul 5, 2015
    Configuration menu
    Copy the full SHA
    0eb3193 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2015

  1. hideCloseButton option 

    Optionally remove the × close button from the modal header
    @rjsmith
    rjsmith committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    bd854e3 View commit details
    Browse the repository at this point in the history

  2. Pass-through of modal options object 

    Optionally allow pass-through of Bootstrap Modal options object,
applied on initialisation of the dialog
    @rjsmith
    rjsmith committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    bb3f7c4 View commit details
    Browse the repository at this point in the history

  3. Updated README for options object pass-through

    @rjsmith
    rjsmith committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    1f46ea1 View commit details
    Browse the repository at this point in the history

  4. Add guard code to prevent intermittent Undefined errors 

    Added guard code to button click event handler to protect access of
this.button.emit function.  In my application, I occasionally see
unreproduceable reported ‘Undefined’ errors on that line.
    @rjsmith
    rjsmith committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    6c2043b View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2015

  1. Merge pull request #2 from rjsmith/master 

    hideCloseButton, modal options and button event guard code
    @jchristman
    jchristman committed Oct 5, 2015
    Configuration menu
    Copy the full SHA
    8038ff2 View commit details
    Browse the repository at this point in the history

  2. Update depedencies and version number

    @jchristman
    jchristman committed Oct 5, 2015
    Configuration menu
    Copy the full SHA
    4caea3d View commit details
    Browse the repository at this point in the history

  3. Update depedencies and version number

    @jchristman
    jchristman committed Oct 5, 2015
    Configuration menu
    Copy the full SHA
    4462762 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2016

  1. Tiny typo 

    Just because it makes it unable to copy the options as is :)
    @jasonnathan
    jasonnathan committed Jan 26, 2016
    Configuration menu
    Copy the full SHA
    0785e2e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2016

  1. Merge pull request #4 from jasonnathan/patch-1 

    Tiny typo
    @jchristman
    jchristman committed Jan 29, 2016
    Configuration menu
    Copy the full SHA
    8cf5044 View commit details
    Browse the repository at this point in the history
Loading
0