👈 Try it on ReadTheDocs

Interestingly, at least #1508 doesn't reproduce on the latest main branch deployment but does on my own one, which uses jupyterlite v0.4.4 as well but uses Pyodide v27 (dev). So perhaps this is an issue that will only materialise with the next Pyodide release?

I did some quick testing with the ReadTheDocs version and uploading large PDFs and notebooks seems to still work

Thanks @juntyr for this! I'll try to have a look soon.

cc @martinRenou who may also be interested

@juntyr maybe it could be a good time to start looking into adding UI tests for file uploads?

We have been tracking that in #1027. Maybe this could have also helped catch such regressions, and help make sure it does not break again later.

If you want the test to be added in this PR, I'll need your help as I've never written a UI test before

If you want the test to be added in this PR, I'll need your help as I've never written a UI test before

I guess it would be fine to do it separately too, since it may need some time. And also since this PR fixes a few issues it would be great to make it available to users sooner.

If you want the test to be added in this PR, I'll need your help as I've never written a UI test before

I guess it would be fine to do it separately too, since it may need some time. And also since this PR fixes a few issues it would be great to make it available to users sooner.

What’s your current timeline for the next path release? If the fix could be released sometime next week it would be fantastic (I’m trying to publish a release of my project before the holidays)

I think we can make a new release now from main, before a 0.5.0 with #1514.

Starting the 0.4.5 release now.

Released: https://github.com/jupyterlite/jupyterlite/releases/tag/v0.4.5

Thanks @juntyr for your fixes! Feel free to report more issues if you find any during your testing.

Released: https://github.com/jupyterlite/jupyterlite/releases/tag/v0.4.5

Thanks @juntyr for your fixes! Feel free to report more issues if you find any during your testing.

Thanks @jtpio for the quick release! I think the pyodide-kernel needs a release as well (with the jupyterlite deps bumped) since its workers bundle the drive contents.

Since I can only test the combination of new jupyterlite + old pyodide-kernel right now, the file size issues appear fixed (this one seems to be in the "inner" layer that the kernel workers call but don't inline), but the file truncation logic doesn't run yet (this one seems to be in the "outer" layer that is inlined in the kernel workers)

I've opened jupyterlite/pyodide-kernel#146