8000 `om ci` sometimes crashes during UTF-8 decoding · Issue #428 · juspay/omnix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

om ci sometimes crashes during UTF-8 decoding #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srid opened this issue Feb 28, 2025 · 4 comments · Fixed by #437
Closed

om ci sometimes crashes during UTF-8 decoding #428

srid opened this issue Feb 28, 2025 · 4 comments · Fixed by #437
Labels
bug Something isn't working

Comments

@srid
Copy link
Member
srid commented Feb 28, 2025 •
edited
Loading

Saw this when first (but not again) building https://github.com/sciexp/python-nix-template

Image 
"name" = "omnix-cli"
"operating_system" = "Mac OS 15.3.1 [64-bit]"
"crate_version" = "1.0.0"
"explanation" = """
Panic occurred in file '/private/tmp/nix-build-omnix-cli-1.0.0.drv-0/source/crates/nix_rs/src/flake/functions/core.rs' at line 99
"""
"cause" = "read stderr: Custom { kind: InvalidData, error: \"stream did not contain valid UTF-8\" }"
"method" = "Panic"
"backtrace" = """

   0: 0x1008d12e0 - __mh_execute_header
   1: 0x10046f3a8 - __mh_execute_header
   2: 0x100470b48 - __mh_execute_header
   3: 0x1005dbfc0 - __mh_execute_header
   4: 0x1007ed2a8 - __mh_execute_header
   5: 0x1007f4010 - __mh_execute_header
   6: 0x1007ea978 - __mh_execute_header
   7: 0x1007e7e68 - __mh_execute_header
   8: 0x1007e85dc - __mh_execute_header
   9: 0x1007a6178 - __mh_execute_header
  10: 0x18f2242e4 - __pthread_deallocate"""

AsyncBufReaderExt's next_line is throwing this:

omnix/crates/nix_rs/src/flake/functions/core.rs

Lines 98 to 103 in e768c5e

let mut reader = BufReader::new(stderr_handle).lines();
while let Some(line) = reader.next_line().await.expect("read stderr") {
if !verbose {
if line.starts_with("• Added input") {
// Consume the input logging itself
reader.next_line().await.expect("read stderr");

@srid srid added the bug Something isn't working label Feb 28, 2025
@srid
Copy link
Member Author
srid commented Feb 28, 2025 •
edited
Loading

https://docs.rs/tokio/latest/tokio/io/trait.AsyncBufReadExt.html#method.read_line

Grok's analysis & solution

Image

@cameronraysmith cameronraysmith mentioned this issue Mar 6, 2025
Closed
@cameronraysmith
Copy link
cameronraysmith commented Mar 11, 2025 •
edited
Loading

You identified this one, but I also encountered it. You may have already seen the backlink to sciexp/python-nix-template#20 .

@cameronraysmith cameronraysmith mentioned this issue Mar 11, 2025
Closed
@srid
Copy link
Member Author
srid commented Mar 11, 2025

Try the read_until branch ... but I need to come up with a proper fix for this.

@cameronraysmith
Copy link

Thank you. Will do.

@srid srid mentioned this issue Mar 11, 2025
Merged
@srid srid closed this as completed in #437 Mar 11, 2025
@srid srid closed this as completed in 8281e85 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Remove 'Added input' filtering. juspay/omnix
2 participants
@srid @cameronraysmith
0