8000 Add template helper for `dynamic_cast`'s · Issue #127 · isledecomp/isle-portable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add template helper for dynamic_cast's #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
foxtacles open 91C2 ed this issue May 19, 2025 · 1 comment
Open

Add template helper for dynamic_cast's #127

foxtacles opened this issue May 19, 2025 · 1 comment

Comments

@foxtacles
Copy link
Member

dynamic_cast's shouldn't fail. Where they do, we need to add logging (or better, an assert)
@MaddTheSane
Copy link

It depends on the reason for the dynamic_cast: If the cast is to test if an object is a kind of class, they shouldn't be changed. if the cast is meant to turn the object explicitly into a specific class, perhaps static_cast would fit better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaddTheSane @foxtacles
0