8000 [Encoding] Revisit the need of EncodingNopLayout resolver · Issue #20846 · iree-org/iree · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Encoding] Revisit the need of EncodingNopLayout resolver #20846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hanhanW opened this issue May 17, 2025 · 1 comment
Open

[Encoding] Revisit the need of EncodingNopLayout resolver #20846

hanhanW opened this issue May 17, 2025 · 1 comment
Assignees
@hanhanW

Comments

@hanhanW
Copy link
Contributor
hanhanW commented May 17, 2025

There are no codegen specifics in the resolver, and we have a similar resolver -- IdentityEncodingAttr. This is the issue for tracking EncodingNopLayout deprecation. We should maybe rename IdentityEncodingAttr to IdentityResolverAttr. I will list out all the encodings, encoding resolvers in #20742 and fix it later.

iree/compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingAttrs.td

Lines 298 to 317 in 1d02350

//===---------------------------------------------------------------------===//
// iree_encoding.identity_encoding
//===---------------------------------------------------------------------===//
def IdentityEncodingAttr :
IREEEncoding_Attr<"IdentityEncoding", [
DeclareAttrInterfaceMethods<IREEEncoding_EncodingLayoutResolverAttrInterface, [
"cloneWithSimplifiedConfig",
"getLayout",
]>
]> {
let mnemonic = "identity_encoding";
let summary = [{A layout resolver that behaves like an identity function.}];
let description = [{
A layout resolver that behaves like an identity function. I.e., it resolves
the layout to the same layout without encodings.
}];
let genVerifyDecl = 0;
}

cc @jtuyls
@hanhanW hanhanW self-assigned this May 17, 2025
@hanhanW
Copy link
Contributor Author
hanhanW commented May 19, 2025

I think the EncodingNopLayout resolver is easier to drop after we finish the interface work and collapse two codegen encoding materialization passes: #20160

I'll help remove it after that. The immediate need is to rename it to identity_resolver and introduce the identity encoding attribute. This reduces the confusion when we abuse pad_encoding_layout with zero values to represent identity layout.

@hanhanW hanhanW mentioned this issue May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanhanW hanhanW

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hanhanW
0