8000 [SYCL] Add number HW threads per EU query by MrSidims · Pull Request #4901 · intel/llvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SYCL] Add number HW threads per EU query #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 15, 2021
Merged

[SYCL] Add number HW threads per EU query #4901

merged 6 commits into from
Dec 15, 2021

Conversation

MrSidims
Copy link
Contributor
@MrSidims MrSidims commented Nov 4, 2021 •
edited
Loading

The appropriate spec update: #4876
Test: intel/llvm-test-suite#550

Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com

@MrSidims MrSidims requested review from againull, smaslov-intel and a team as code owners November 4, 2021 20:43
@MrSidims MrSidims mentioned this pull request Nov 4, 2021
Closed
@MrSidims MrSidims force-pushed the private/MrSidims/GPURTHWThreadImpl branch from b02c2ca to b0aa21e Compare November 4, 2021 20:46
MrSidims added a commit to MrSidims/llvm-test-suite that referenced this pull request Nov 4, 2021
@MrSidims
[SYCL] Add a test for HW threads per EU device_info query
bbfb3b6 
Spec update: intel/llvm#4876
Implementation: intel/llvm#4901

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
steffenlarsen
steffenlarsen previously approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor
@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor request, but otherwise LGTM.

@MrSidims MrSidims marked this pull request as draft November 5, 2021 14:49
@MrSidims
Copy link
Contributor Author
MrSidims commented Nov 5, 2021

Tentatively converted to draft since I want #4876 be approved first before merging the implementation.

@MrSidims MrSidims force-pushed the private/MrSidims/GPURTHWThreadImpl branch from 08bc97e to d1e6d59 Compare November 13, 2021 07:25
@MrSidims MrSidims marked this pull request as ready for review November 13, 2021 07:25
steffenlarsen
steffenlarsen previously approved these changes Nov 15, 2021
View reviewed changes
@MrSidims
Copy link
Contributor Author

@smaslov-intel @againull could you please take a look?

@MrSidims
[SYCL] Add number HW threads per EU query
eea7b42 
The appropriate spec update: intel#4876
Test: intel/llvm-test-suite#550

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims
Add checks for hip and opencl
6565686 
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims
Fix abi test
c35b7c0 
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims MrSidims force-pushed the private/MrSidims/GPURTHWThreadImpl branch from d1e6d59 to c35b7c0 Compare November 23, 2021 08:43
@MrSidims
Copy link
Contributor Author

@smaslov-intel ping

@MrSidims
Update SYCL_EXT_INTEL_DEVICE_INFO macro
0d06cf2 
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims
Apply the comments
d4bbe4c 
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
smaslov-intel
smaslov-intel previously approved these changes Nov 23, 2021
View reviewed changes
@MrSidims
Fix ABI test
7eb3053 
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author
MrSidims commented Nov 23, 2021 •
edited
Loading

Fixed ABI test. @bader , guess I have both required approvals.

@bader
Copy link
Contributor
bader commented Nov 24, 2021

Fixed ABI test. @bader , guess I have both required approvals.

The intel/llvm-test-suite#550 validation status is unclear. I see a lot of failures. Are they caused by this patch?

MrSidims added a commit to MrSidims/llvm-test-suite that referenced this pull request Dec 8, 2021
@MrSidims
[SYCL] Add a test for HW threads per EU device_info query
b14b887 
Spec update: intel/llvm#4876
Implementation: intel/llvm#4901

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims MrSidims mentioned this pull request Dec 8, 2021
Merged
@MrSidims
Copy link
Contributor Author
MrSidims commented Dec 8, 2021

/verify with intel/llvm-test-suite#550

1 similar comment
@vladimirlaz
Copy link
Contributor

/verify with intel/llvm-test-suite#550

@MrSidims
Copy link
Contributor Author

/verify with intel/llvm-test-suite#606

@MrSidims
Copy link
Contributor Author

@bader @vladimirlaz are we good to merge the PRs ? Assertions seems to be a known issue. I'll report mismatches between 505 and 606 test PR results internally.

@vladimirlaz vladimirlaz merged commit 2e798df into intel:sycl Dec 15, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Dec 15, 2021
@alexbatashev
Merge remote-tracking branch 'upstream/sycl' into containers_docs
5ff13fa 
* upstream/sycl: (5961 commits)
  [SYCL] Implement discard_events extension (intel#5026)
  [SYCL][NFC] Fix unused parameter warning in piQueueFlush (intel#5139)
  [SYCL][XPTI] Fix static analysis tool warnings (intel#5040)
  [CI] Switch post-commit jobs to self-hosted runners (intel#5147)
  [SYCL] Fix support for classes i
8000
mplicitly converted from items in parallel_for (intel#5118)
  [SYCL][HIP] Fix platform query in USM alloc info (intel#5140)
  [Docker] Add workarounds for two SYCL issues (intel#5143)
  [CI] Install cm-compiler in drivers image (intel#5128)
  [ESIMD] Add support for an arbitrary number of elements to simd::copy_from/to (intel#5135)
  [SYCL] Add number HW threads per EU query (intel#4901)
  [CI] Refactor workflow files (intel#5134)
  [CI] Enable HIP and CUDA plugins in GitHub Actions builds (intel#5087)
  [SYCL] Implement queue flushing (intel#5052)
  Disable issue labeler in LLVM forks
  Modify translation for disable_loop_pipelining metadata
  Add SPIR-V friendly translation for OpLoad and OpStore
  Fix return type postfix for SPIR-V Friendly IR
  Restrict special handling of sampler OpVariable only to UniformConstant
  Add lowering for llvm.bswap intrinsic
  Fix translation of OpVariable with OpSamplerType
  ...
vladimirlaz pushed a commit to intel/llvm-test-suite that referenced this pull request Dec 16, 2021
@MrSidims
[SYCL] Add a test for HW threads per EU device_info query (#606)
a794ded 
Spec update: intel/llvm#4876
Implementation: intel/llvm#4901

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@MrSidims
[SYCL] Add a test for HW threads per EU device_info query (intel/llvm…
72c4047 
…-test-suite#606)

Spec update: intel#4876
Implementation: intel#4901

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@againull againull Awaiting requested review from againull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrSidims @bader @vladimirlaz @smaslov-intel @steffenlarsen
0