8000 [Critical] Fix crashes: Eng Lang Version + Revert source code comments back to English · Issue #409 · indiff/qttabbar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Critical] Fix crashes: Eng Lang Version + Revert source code comments back to English #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Runnin-N-Gunnin opened this issue Apr 10, 2025 · 2 comments
Open

[Critical] Fix crashes: Eng Lang Version + Revert source code comments back to English #409

Runnin-N-Gunnin opened this issue Apr 10, 2025 · 2 comments
Assignees
@indiff
Labels
bug Something isn't working

Comments

@Runnin-N-Gunnin
Copy link
Runnin-N-Gunnin commented Apr 10, 2025 •
edited
Loading

First of all thanks to indiff and any other contributor to this project. Chinese people make some really great software and I have absolutely zero problems with your language or country. The issue is NOT that people are speaking or writing in another language but rather the incompatibility issues that arise, in a programming context.

QTTabBar is a already a successful software with it's 4.2k github stars. Unfortunately, it has problems, some which have been ignored for a long time. The Eng Lang version of QTTabBar mostly works, but often crashes. So this is my attempt - because I'm not ready to give up on QTTabBar just yet - to describe some of the issues and make a few suggestions.

The original qttabbar source code contained code comments in English and by replacing it with Chinese we get a lot of issues in Visual Studio (English version) when opening the project. VS default language is in English, remember.

The About section in this github project is in English. The readme contains English. Everyone will assume that it will work properly with their Windows set to English but for many, it does not! Plenty of people who uses the Eng Lang version have reported crashes but are met with complete silence even though the issues would be easy to fix.

I would fix it myself but I can't because: Those who speaks/understands English but not Chinese are essentially excluded from contributing code/fixes/improvements to qttabbar! Unless one understands Chinese it's impossible to navigate the code and understand what's going on.

- Revert all source code comments back to English

First of all, everytime I open a .cs file in the project solution I'm presented with an error message ("....unicode substitution character..."). It's because I'm using English VS and the .cs file contains chinese code comments.

I recently wanted to make my own plugin only to find that someone changed every comment from English to Chinese in every SamplePlugin project. I assume many have dropped making their own plugins (and many would've shared them with others here on github!) because of this. This is very bad for the project in my opinion.

At the very least, let us English speakers understand the Plugin Samples provided so we can make our own.

Even the QTTabBarException.log contains Chinese language making it difficult to understand why qttabbar crashed.

Suggestion: Revert all source code comments back to English. This will enhance your project by making it accessible to so many more people. The developers write code in English so it makes sense to keep everything else also in English. Even indiff's github profile is written in English!

- Fix Eng Lang Version

This is much more critical than my first point.

For me, ~90% of the times qttabbar crashes it's because of some language issue. DateTime format issues, etc. Basically, globalization issues.

This is how Microsoft describes globalization:

Globalization involves designing and developing a world-ready app that supports localized interfaces and regional data for users in multiple cultures. Before beginning the design phase, you should determine which cultures your app will support. Although an app targets a single culture or region as its default, you can design and write it so that it can easily be extended to users in other cultures or regions.

As developers, we all have assumptions about user interfaces and data that are formed by our cultures. For example, for an English-speaking developer in the United States, serializing date and time data as a string in the format MM/dd/yyyy hh:mm:ss seems perfectly reasonable. However, deserializing that string on a system in a different culture is likely to throw a FormatException exception or produce inaccurate data. Globalization enables us to identify such culture-specific assumptions and ensure that they do not affect our app's design or code.

This article discusses some of the major issues you should consider and the best practices you can follow when handling strings, date and time values, and numeric values in a globalized app.

For example, my qttabbar is set to Eng Lang. But it uses Chinese datetime formatting, writing it to my Registry, then Windows tries to read it. This can cause crashes. It's simple things like that.

Looking at QTTabBarException.log, every single one of the crashes has been reported here before but again are met with complete silence. Anyone who uses Eng Lang and experience these crashes are simply ignored.

Again, I would help fix it but then again I can't understand any of the source code comments (refer to my first point).

Suggestion 1: Fix these issues. Many easy fixes probably. Just look for github issues written in English.

Suggestion 2: During testing, use Windows with English language AND Chinese/Other language.

Suggestion 3: Since the very core of the Windows operating system is written in English, from the programming language to the very internals; make sure it works on English Windows before you optimize it for Chinese (or other languages).

Would very much appreciate a response from indiff and/or every active contributor - even a short comment!Thanks!
@Runnin-N-Gunnin Runnin-N-Gunnin added the bug Something isn't working label Apr 10, 2025
@Runnin-N-Gunnin
Copy link
Author

pinging @qwop - if you're still contributing to QTTabBar, would you mind having a quick look at this?

@indiff
Copy link
Owner
indiff commented Apr 11, 2025

这个致命的日期问题， 很早就遇到了。 我会想办法去修复，感谢使用！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indiff indiff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indiff @Runnin-N-Gunnin
0