8000 [Actomaton] Fix pending effects not being cancelled by inamiy · Pull Request #46 · Actomaton/Actomaton · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Actomaton] Fix pending effects not being cancelled #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2022
Merged

[Actomaton] Fix pending effects not being cancelled #46

merged 2 commits into from
May 8, 2022

Conversation

inamiy
Copy link
Member
@inamiy inamiy commented May 8, 2022

This PR fixes cancellation bug when effect is suspended by specific EffectQueue policy e.g. Oldest1SuspendNewEffectQueueProtocol.

  • As Is:
    • After cancellation of either running & suspended effects, suspended effects will become active because they don't get cancelled but only running ones will get cancelled so that there will be enough spaces to run suspended ones.
  • To Be:
    • Always cancel suspended effects gracefully.

@inamiy inamiy added the bug Something isn't working label May 8, 2022
@inamiy inamiy added this to the 0.5.2 milestone May 8, 2022
@inamiy inamiy self-assigned this May 8, 2022
@inamiy inamiy merged commit 723616a into main May 8, 2022
@inamiy inamiy deleted the Actomaton/fix-pending-effects-cancellation branch May 8, 2022 12:40
This was referenced May 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inamiy inamiy

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@inamiy
0