8000 Incorrect percent encoding under Sonoma · Issue #4861 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content < 10000 script crossorigin="anonymous" type="application/javascript" src="https://github.githubassets.com/assets/keyboard-shortcuts-dialog-b3dd4b1cb532.js" defer="defer">
Incorrect percent encoding under Sonoma #4861
Closed
@low-batt

Description

@low-batt

System and IINA version:

  • macOS 14.4
  • IINA 1.3.4

Expected behavior:
IINA correctly percent encodes URLs.

Actual behavior:
When running under macOS Sonoma IINA will perform percent encoding twice resulting in malformed URLs. @xfoxfu provided two examples:

Opening this URL in Firefox:

iina://weblink?url=https://example.com/%5Bfoo%20bar.mkv

IINA changes %5Bfoo%20bar.mkv to be %5Bfoo%2520bar.mkv:

13:54:42.969 [iina][d] Parsing URL iina://weblink?url=https://example.com/%5Bfoo%20bar.mkv
13:54:42.969 [player0][d] Open URL: https://example.com/%5Bfoo%2520bar.mkv
13:54:42.969 [player0][d] Opening https://example.com/%5Bfoo%2520bar.mkv in main window

Opening this URL in Firefox:

iina://weblink?url=https://example.com/%25foo%20bar.mkv

IINA changes %25foo%20bar.mkv to be %25foo%2520bar.mkv:

13:51:00.896 [iina][d] Parsing URL iina://weblink?url=https://example.com/%25foo%20bar.mkv
13:51:00.897 [player0][d] Open URL: https://example.com/%25foo%2520bar.mkv
13:51:00.897 [player0][d] Opening https://example.com/%25foo%2520bar.mkv in main window

This is a change from the behavior under macOS Ventura.

Steps to reproduce:

  • Enable logging in IINA

  • Open one of the URLs given above in Firefox

  • Look for the message shown above in IINA's log file

  • MPV does not have this problem.

This is an issue with IINA code. I have not checked if mpv also has this problem.

How often does this happen?
Every time.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0