8000 Playback History searches don't work for capital letters · Issue #3800 · iina/iina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Playback History searches don't work for capital letters #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
svobs opened this issue Jun 6, 2022 · 3 comments · Fixed by #3801
Closed

Playback History searches don't work for capital letters #3800

svobs opened this issue Jun 6, 2022 · 3 comments · Fixed by #3801
Assignees
@svobs
Labels
progress: fixed/implemented

Comments

@svobs
Copy link
Contributor
svobs commented Jun 6, 2022

System and IINA version:

  • macOS 12.4
  • IINA 1.3.0 build 131

Expected behavior:
If a file is listed in Playback History window, searching for its exact name should find it.

Actual behavior:
Searches that include a capital letter will never find anything, even if the filename has that exact capital letter.

Steps to reproduce:

  1. Play a file

Screen Shot 2022-06-06 at 00 14 23

  1. Search using a capital letter

Screen Shot 2022-06-06 at 00 14 39

How often does this happen?
Always
@svobs
Copy link
Contributor Author
svobs commented Jun 6, 2022

I was able to identify the problem right away and thus the specific name. Will submit PR

@svobs svobs mentioned this issue Jun 6, 2022
Merged
2 tasks
@uiryuu uiryuu closed this as completed Sep 22, 2022
@low-batt
Copy link
Contributor

The fix in PR #3801 has been merged into the develop branch.

Keeping this issue open until the fix is in a released version of IINA.

@low-batt low-batt reopened this Sep 25, 2022
@low-batt low-batt linked a pull request Oct 18, 2022 that will close this issue
Fix bug: Playback History search returns no results for uppercase letters #3801
Merged
2 tasks
@low-batt
Copy link
Contributor
low-batt commented Nov 7, 2022

Fixed in IINA 1.3.1

@low-batt low-batt closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svobs svobs

Labels
progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug: Playback History search returns no results for uppercase letters svobs/iina-advance
3 participants
@svobs @uiryuu @low-batt
0