Window not resized when screen changes in legacy full screen mode #3715
Assignees
Labels
Comments
low-batt
added a commit
to low-batt/iina
that referenced
this issue
May 4, 2022
The commit updates MainWindowController to resize the window appropriately when the screen the window is on changes if in legacy full screen mode. The commit in the pull request will: - Add a method setFrame to Extensions.NSScreen to set a window's frame and content view frame to use the full screen - Add call to setFrame in observer for didChangeScreenParametersNotification
2 tasks
|
The commit in the pull request will:
|
low-batt
added a commit
to low-batt/iina
that referenced
this issue
May 6, 2022
Rebased and resolved merge conflicts. Fixed setting of content view height. The commit updates MainWindowController to resize the window appropriately when the screen the window is on changes if in legacy full screen mode. The commit in the pull request will: - Add a method setFrame to Extensions.NSScreen to set a window's frame and content view frame to use the full screen - Add call to setFrame in observer for didChangeScreenParametersNotification
low-batt
added a commit
to low-batt/iina
that referenced
this issue
May 7, 2022
Address review comments: - Rename setFrame to setWindowFrameForLegacyFullScreen - Move method from Extensions to MainWindowController - Refactor accordingly
lhc70000
pushed a commit
that referenced
this issue
May 9, 2022
* Fix window not resized when screen changes, #3715 Rebased and resolved merge conflicts. Fixed setting of content view height. The commit updates MainWindowController to resize the window appropriately when the screen the window is on changes if in legacy full screen mode. The commit in the pull request will: - Add a method setFrame to Extensions.NSScreen to set a window's frame and content view frame to use the full screen - Add call to setFrame in observer for didChangeScreenParametersNotification * Fix window not resized when screen changes, #3715 Address review comments: - Rename setFrame to setWindowFrameForLegacyFullScreen - Move method from Extensions to MainWindowController - Refactor accordingly
|
The fix in PR #3719 has been merged into the develop branch. |
|
Closing. Fixed in IINA 1.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System and IINA version:
Expected behavior:
When IINA is playing in legacy full screen mode on an external monitor and that monitor is disconnected when macOS moves the window to the internal monitor the window should be resized to fit the internal monitor.
Actual behavior:
The window is not resized.
Steps to reproduce:
Use legacy full screenis in preferencesVideomenu selectEnter Full ScreenAt this point if the size of the external monitor differs from the internal monitor the IINA window is not resized to properly fit the internal monitor.
Legacy full screen is an IINA feature.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: