Trash handling is too high level for FileUtil, move it up. #20261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix libretro's build: https://git.libretro.com/libretro/ppsspp/-/jobs/6728765
Trash is a shell-level thing, and is a bit too high level to be in FileUtil.cpp anyway. We don't want to link that functionality into the libretro build for example, so it's better that we make it a "system request".
When I moved out the zip file content detection, I slightly messed up, so fixing that too.
This makes the coming Mac implementation much easier too.
Also bump pspautotests, though we haven't activated any new tests.