Add back our older VFPU approximations, as fallbacks if the table files are missing #17228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing. PR #16984 added more accurate versions of these functions, but they require large lookup tables stored in assets/. If these files are missing, PPSSPP would simply crash, which isn't good. We should probably try to warn the user somehow that these files are missing, though...
5 tasks
|
The CoreUWP.vcxproj file has the EDIT: For the missing assets, we could just add them in a similar way I did for the missing shader, debugger, and other assets files too (EDIT 2: nvm, saw they were added) |
|
It's MSVC screwing it up, gah. Not sure it's worth removing since it keeps coming back, but did it anyway. |
Guess we'll just give up on it next time it comes back. Maybe it's more worthwhile to edit the files manually in the long term? That way the MSVC quirks aren't a factor? |
unknownbrackets
approved these changes
Apr 4, 2023
|
Yeah, I think I'll re-do how this works. But this at least fixes the crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16984 added more accurate versions of these functions, but they require large lookup tables stored in assets/.
If these files are missing, PPSSPP would simply crash, which isn't good. It's very common for assets files to be missing when running as a libretro core, because those users just don't seem to be in the habit of copying these when they install a core.
We should probably try to warn the user somehow that these files are missing, though...
This also fixes deployment of the table files on UWP builds (some additional files snuck in too, without me explicitly adding them.. might as well let them, they're just gonna get auto-added again later and don't do any harm)