8000 Fixed rfxtrx binary_sensor off command by basschipper · Pull Request #8160 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixe 8000 d rfxtrx binary_sensor off command #8160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2017
Merged

Fixed rfxtrx binary_sensor off command #8160

merged 2 commits into from
Jun 22, 2017

Conversation

basschipper
Copy link
Contributor
@basschipper basschipper commented Jun 22, 2017 •
edited
Loading

Description:

Fixed rfxtrx binary_sensor off command implementation, the needed code was already in the rfxtrx component. Now, a binary rfxtrx sensor can be turned off by the device's off command OR a configured off_delay time.
In addition, fixed some deprecation warnings (sensor_class / update_ha_state()).

Test with: KaKu AMST-606 & AYCT-102

Related issue (if applicable): fixes # #6794 (comment)

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2336

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
binary_sensor:
  platform: rfxtrx
  automatic_add: True
  devices:
    091300006ca2c6001080:
      name: motion_hall
      device_class: motion
      off_delay:
        seconds: 5
    0913000022670e013b70:
      name: window_room2
      device_class: opening
      data_bits: 4
      command_on: 0x0e
      command_off: 0x07

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@basschipper basschipper mentioned this pull request Jun 22, 2017
Merged
8 tasks
@Danielhiversen Danielhiversen merged commit fe93b51 into home-assistant:dev Jun 22, 2017
@balloob balloob mentioned this pull request Jul 1, 2017
Merged
@ypollart ypollart mentioned this pull request Jul 18, 2017
Merged
8 tasks
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@basschipper 8900 @dethpickle
Fixed rfxtrx binary_sensor off command (home-assistant#8160)
bc50a33 
* Fixed applying rfxtrx binary off command

* Fixed some deprecation issues
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
@basschipper basschipper deleted the rfxtrx-binarysensor-command-off-fix branch February 28, 2018 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed component integration: rfxtrx platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@basschipper @Danielhiversen @balloobbot @homeassistant
0