8000 Fix Emulated Hue AttributeError: 'NoneType' object has no attribute '… by croghostrider · Pull Request #26018 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Emulated Hue AttributeError: 'NoneType' object has no attribute '… #26018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2019
Merged

Fix Emulated Hue AttributeError: 'NoneType' object has no attribute '… #26018

merged 3 commits into from
Sep 4, 2019

Conversation

croghostrider
Copy link
Contributor
@croghostrider croghostrider commented Aug 17, 2019 •
edited
Loading

Description:

Fix crash if a device tries to check the state of a non-existing entry

Related issue (if applicable): fixes #24728

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@probot-home-assistant probot-home-assistant bot added integration: emulated_hue small-pr PRs with less than 30 lines. labels Aug 17, 2019
@croghostrider
Copy link
Contributor Author

there is already a test
https://github.com/home-assistant/home-assistant/blob/fed789c770d033521658b5afac37712c64c7ceec/tests/components/emulated_hue/test_hue_api.py#L584-L588
but on a real installation, if a device tries to check a non-exicting entry.
Is the response status 500 and not 404.
I do not know, why the test passes in tox.

image

@narfel narfel mentioned this pull request Aug 29, 2019
Closed
@MartinHjelmare MartinHjelmare requested a review from balloob August 31, 2019 10:37
@balloob balloob merged commit b968b53 into home-assistant:dev Sep 4, 2019
@lock lock bot locked and limited conversation to collaborators Sep 5, 2019
@croghostrider croghostrider deleted the fix-AttributeError branch September 8, 2019 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed integration: emulated_hue small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emulated Hue: AttributeError: 'NoneType' object has no attribute 'lower'
3 participants
@croghostrider @balloob @homeassistant
0