8000 Daikin integration duplicated · Issue #36635 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Daikin integration duplicated #36635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sagitt opened this issue Jun 10, 2020 · 12 comments · Fixed by #36704
Closed

Daikin integration duplicated #36635

sagitt opened this issue Jun 10, 2020 · 12 comments · Fixed by #36704
Labels
integration: daikin

Comments

@sagitt
Copy link
sagitt commented Jun 10, 2020

The problem

I have not daikin in yaml mode, removed it with 0.110, after 0.111 upgrade i see 2 new daikin integration discovered...... so i removed my configured daikin thinking a configuration issue, restarted, and now i see 4 daikin integration. 2 ignorable, 2 not ignorable.

for now fixed configuring 2 not ignorable and ignore other 2.

Environment

  • Home Assistant Core release with the issue: 0.11
  • Last working Home Assistant Core release (if known): 0.110.X
  • Operating environment (Home Assistant/Supervised/Docker/venv): hassos
  • Integration causing this issue: Daikin
  • Link to integration documentation on our website:

Problem-relevant configuration.yaml



Traceback/Error logs





Additional information


Schermata 2020-06-10 alle 19 33 01

      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
            







      

  
      



  

  @probot-home-assistant





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  
    

  




      


        


  
    

      
          
daikin documentation

daikin source

(message by IssueLinks)

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @probot-home-assistant





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  
    

  




      


        


  
    

      
          
Hey there @fredrike, mind taking a look at this issue as its been labeled with a integration (daikin) you are listed as a codeowner for? Thanks!

(message by CodeOwnersMention)

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @fredrike





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          
@sagitt does your devices support zeroconf?


This is partly solved in #36571.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @sagitt





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  Author


  


  
    

      

      
            sagitt
  

      

      

      commented


        Jun 10, 2020


      
    


  




      


        


  
    

      
          


@sagitt does your devices support zeroconf?


This is partly solved in #36571.




i have 2 daikin emura with wi-fi card

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @fredrike





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          




@sagitt does your devices support zeroconf?

This is partly solved in #36571.




i have 2 daikin emura with wi-fi card




Does the Emura support zeroconf?

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @astrandb





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          
Same problem here with HA 111.1

I have no yaml entry.

First configured Daikin integration instance works fine. (No API key and no password entered). Discovery panel reapperas immediately with no option to ignore.

Have tried all reasonable combinations of deleting integration and restarting HA without any success.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @fredrike





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

      

      
            fredrike
  

      

      

      commented


        Jun 12, 2020


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
  
        
      Loading


  
    
  



    


  




      


        


  
    

      
          
I'm terrible sorry for this issue. As my Daikin unit doesn't support Zeroconf I implemented that support in blind.


@MartinHjelmare, would it be ok to use say https://pypi.org/project/getmac/, during the zeroconf flow to resolve the hostname to a mac? The other solution would be to check if hostname is available (it might be for some units) and use that instead of mac for unique id but that would require a lot of work.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @MartinHjelmare





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  
    

  




      


        


  
    

      
          
Yes, that's ok. But be aware that getting the mac address of a host successfully depends on the network set up, and might not work in all cases.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @fredrike





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          


But be aware that getting the mac address of a host successfully depends on the network set up, and might not work in all cases.




I don't think Zeroconf works if the network isn't set up 🙈 .

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  

    
  


  

      

    @fredrike
fredrike



    mentioned this issue
    
      Jun 12, 2020
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    20 tasks
  





  









      

  
      



  

  @fredrike





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          
Would be great if someone with a Zeroconf device could test: #36704

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @astrandb





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          
Below is a debug log from HA 111.1 without #36704

I have not touched anything, just waited a few minutes


2020-06-12 08:45:50 DEBUG (MainThread) [homeassistant.components.daikin.config_flow] Zeroconf discovery_info: {'host': '192.168.0.66', 'port│0 packages can be updated.
': 80, 'hostname': 'DaikinAP51913.local.', 'type': '_dkapi._tcp.local.', 'name': 'DkApi._dkapi._tcp.local.', 'properties': {'_raw': {'reg': │0 updates are security updates.
b'eu', 'type': b'aircon', 'ver': b'1_2_51', 'adp_kind': b'3'}, 'reg': 'eu', 'type': 'aircon', 'ver': '1_2_51', 'adp_kind': '3'}}            │
2020-06-12 08:46:27 DEBUG (MainThread) [homeassistant.components.daikin.config_flow] Discovered device: {'id': '409F38D0FF8C', 'name': 'Serv│
errum', 'ip': '192.168.0.66', 'mac': '409F38D0FF8C', 'ver': '1_2_51'}


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @fredrike





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  
    

  




      


        


  
    

      
          


Below is a debug log from HA 111.1 without #36704

I have not touched anything, just waited a few minutes


2020-06-12 08:45:50 DEBUG (MainThread) [homeassistant.components.daikin.config_flow] Zeroconf discovery_info: {'host': '192.168.0.66', 'port│0 packages can be updated.
': 80, 'hostname': 'DaikinAP51913.local.', 'type': '_dkapi._tcp.local.', 'name': 'DkApi._dkapi._tcp.local.', 'properties': {'_raw': {'reg': │0 updates are security updates.
b'eu', 'type': b'aircon', 'ver': b'1_2_51', 'adp_kind': b'3'}, 'reg': 'eu', 'type': 'aircon', 'ver': '1_2_51', 'adp_kind': '3'}}            │
2020-06-12 08:46:27 DEBUG (MainThread) [homeassistant.components.daikin.config_flow] Discovered device: {'id': '409F38D0FF8C', 'name': 'Serv│
errum', 'ip': '192.168.0.66', 'mac': '409F38D0FF8C', 'ver': '1_2_51'}





Thanks! It is as I suspected, the old discovery method is interfering with the new Zeroconf discovery.


This runs the patch in a docker container:

docker run --name=hadev -p 8123:8123 -it python:3.8 sh -c 'apt-get update; apt-get install -y python3-pip python3.7-dev python3.7-venv python-wheel-common autoconf libssl-dev libxml2-dev libxslt1-dev libjpeg-dev libffi-dev libudev-dev zlib1g-dev libavformat-dev libavcodec-dev libavdevice-dev libavutil-dev libswscale-dev libavresample-dev libavfilter-dev; git clone -b daikin-config_flow --single-branch https://github.com/fredrike/home-assistant.git /home-assistant; cd /home-assistant; git reset --hard; git pull; pip install sqlalchemy; script/setup; hass'

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
            

    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    integration: daikin









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      Fix Daikin discovery

    
      fredrike/home-assistant
    





      
    

  




      

    

  
      

  

    

      5 participants
    

    

        
          @sagitt 
        
          @frenck 
        
          @fredrike 
        
          @MartinHjelmare 
        
          @astrandb 
    

  






    

    




    






  

          

        



    



  





    

  


  


          



    



  

    

    

    





    


    

    

  



0