8000 feat: side-channel for nested record datas by hjdivad · Pull Request #1745 · ember-m3/ember-m3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: side-channel for nested record datas #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

hjdivad
Copy link
Collaborator
@hjdivad hjdivad commented Apr 6, 2023

Update embedded model creation to go via the store wrapper.

This allows downstreams to override createNestedRecordData in case they have any custom record data code.

@hjdivad hjdivad force-pushed the hjdivad/side-channel-nested-record-datas branch from 18de978 to e7b946c Compare April 11, 2023 17:16
@hjdivad hjdivad added the enhancement ch:enhancement label Apr 11, 2023
@hjdivad hjdivad marked this pull request as ready for review April 11, 2023 17:17
@hjdivad hjdivad enabled auto-merge April 11, 2023 17:17
@hjdivad hjdivad force-pushed the hjdivad/side-channel-nested-record-datas branch from e7b946c to 76a9f4b Compare April 11, 2023 17:28
@hjdivad hjdivad disabled auto-merge April 11, 2023 17:53
@hjdivad hjdivad merged commit 49e89cc into master Apr 11, 2023
@hjdivad hjdivad deleted the hjdivad/side-channel-nested-record-datas branch April 11, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ch:enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0