8000 Comparing v0.28.1...main · heroku/libcnb.rs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: heroku/libcnb.rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.28.1
Choose a base ref
...
head repository: heroku/libcnb.rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 10 commits
  • 19 files changed
  • 7 contributors

Commits on Apr 1, 2025

  1. Bump the github-actions group with 2 updates (#928)

    Bumps the github-actions group with 2 updates: [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) and [buildpacks/github-actions](https://github.com/buildpacks/github-actions).
    
    
    Updates `Swatinem/rust-cache` from 2.7.7 to 2.7.8
    - [Release notes](https://github.com/swatinem/rust-cache/releases)
    - [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md)
    - [Commits](Swatinem/rust-cache@f0deed1...9d47c6a)
    
    Updates `buildpacks/github-actions` from 5.8.9 to 5.8.10
    - [Release notes](https://github.com/buildpacks/github-actions/releases)
    - [Commits](buildpacks/github-actions@0f05ba4...d82294e)
    
    ---
    updated-dependencies:
    - dependency-name: Swatinem/rust-cache
      dependency-version: 2.7.8
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    - dependency-name: buildpacks/github-actions
      dependency-version: 5.8.10
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    a9c822a View commit details
    Browse the repository at this point in the history
  2. Add tracing-opentelemetry to the OTel crate Dependabot group (#931)

    Since its version is closely tied to that of the other `opentelemetry*`
    crates, so it should be grouped/updated in the same Dependabot PR
    as them.
    
    xref #930
    edmorley authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    5f2a7f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2025

  1. Update repo metadata (#933)

    Signed-off-by: Pablo Temporini <ptemporini@salesforce.com>
    pablotemporini authored Apr 3, 2025
    Configuration menu
    Copy the full SHA
    536bb07 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2025

  1. Update petgraph requirement from 0.7.1 to 0.8.1 (#934)

    * Update petgraph requirement from 0.7.1 to 0.8.1
    
    8000
    
    Updates the requirements on [petgraph](https://github.com/petgraph/petgraph) to permit the latest version.
    - [Release notes](https://github.com/petgraph/petgraph/releases)
    - [Changelog](https://github.com/petgraph/petgraph/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/petgraph/petgraph/compare/petgraph@v0.7.1...petgraph@v0.8.1)
    
    ---
    updated-dependencies:
    - dependency-name: petgraph
      dependency-version: 0.8.1
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    * Enable `std` feature for petgraph
    
    ---------
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
    dependabot[bot] and edmorley authored Apr 16, 2025
    Configuration menu
    Copy the full SHA
    de6205b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2025

  1. Fix clippy::io_other_error lint in newer Rust (#937)

    The `clippy::io_other_error` lint has been added to Rust beta:
    https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
    
    ```
    warning: this can be `std::io::Error::other(_)`
      --> libherokubuildpack/src/fs.rs:33:28
       |
    33 | ...|| std::io::Error::new(ErrorKind::Other, "std::fs::read_dir unexpectedly returned an entry that is not in the directory that was read."))?;
       |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
       = note: `#[warn(clippy::io_other_error)]` on by default
    help: use `std::io::Error::other`
       |
    33 -             .ok_or_else(|| std::io::Error::new(ErrorKind::Other, "std::fs::read_dir unexpectedly returned an entry that is not in the directory that was read."))?;
    33 +             .ok_or_else(|| std::io::Error::other("std::fs::read_dir unexpectedly returned an entry that is not in the directory that was read."))?;
       |
    ```
    
    GUS-W-18337923.
    edmorley authored Apr 22, 2025
    Configuration menu
    Copy the full SHA
    c46721f View commit details
    Browse the repository at this point in the history

Commits on May 1, 2025

  1. Bump the github-actions group with 2 updates (#940)

    Bumps the github-actions group with 2 updates: [buildpacks/github-actions](https://github.com/buildpacks/github-actions) and [softprops/action-gh-release](https://github.com/softprops/action-gh-release).
    
    
    Updates `buildpacks/github-actions` from 5.8.10 to 5.8.11
    - [Release notes](https://github.com/buildpacks/github-actions/releases)
    - [Commits](buildpacks/github-actions@d82294e...c502bcf)
    
    Updates `softprops/action-gh-release` from 2.2.1 to 2.2.2
    - [Release notes](https://github.com/softprops/action-gh-release/releases)
    - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
    - [Commits](softprops/action-gh-release@c95fe14...da05d55)
    
    ---
    updated-dependencies:
    - dependency-name: buildpacks/github-actions
      dependency-version: 5.8.11
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    - dependency-name: softprops/action-gh-release
      dependency-version: 2.2.2
      dependency-type: direct:production
      update-ty
    8000
    pe: version-update:semver-patch
      dependency-group: github-actions
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored May 1, 2025
    Configuration menu
    Copy the full SHA
    2bde8c4 View commit details
    Browse the repository at this point in the history
  2. Bump actions/create-github-app-token from 1 to 2 (#941)

    Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 1 to 2.
    - [Release notes](https://github.com/actions/create-github-app-token/releases)
    - [Commits](actions/create-github-app-token@v1...v2)
    
    ---
    updated-dependencies:
    - dependency-name: actions/create-github-app-token
      dependency-version: '2'
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored May 1, 2025
    Configuration menu
    Copy the full SHA
    3b88883 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2025

  1. Fix default target triple for cargo libcnb package (#922)

    * Allow tests to target a specific platform
    
    Also picks better defaults for the test runner and `libcnb package`.
    
    Fixes #843
    Fixes #869
    
    * Update CHANGELOG.md
    
    * Revert libcnb-test changes, limit scope to just determining a default target triple.
    
    Fixes #843
    Fixes #869
    
    * Update CHANGELOG.md
    
    Signed-off-by: Colin Casey <casey.colin@gmail.com>
    
    * Update CHANGELOG.md
    
    Signed-off-by: Colin Casey <casey.colin@gmail.com>
    
    * Update CHANGELOG.md
    
    Signed-off-by: Colin Casey <casey.colin@gmail.com>
    
    ---------
    
    Signed-off-by: Colin Casey <casey.colin@gmail.com>
    colincasey authored May 2, 2025
    Configuration menu
    Copy the full SHA
    88758ae View commit details
    Browse the repository at this point in the history
  2. Prepare release v0.29.0 (#942)

    Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
    heroku-linguist[bot] authored May 2, 2025
    Configuration menu
    Copy the full SHA
    b8d6835 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2025

  1. Fix auto PATH ordering (#938)

    * Failing test for #900
    
    * Add a delimiter to the path
    
    Missing delimiter strikes again
    
    * Fix auto PATH ordering
    
    In #900, I observed that the path of a layer's `./bin` dir (if present) is appended to any explicitly added paths by CNB lifecycle. Libcnb instead prepends the path.
    
    This is fixed to match the upstream implementation by changing the order of path evaluation.
    
    Close #900
    
    * Test Build and Launch scope
    
    * Expected before actual in assertion
    
    * Test LIBRARY_PATH ordering
    
    * Changelog
    
    * Doc whitespace and headers
    
    * Update docs s/append/prepend/
    
    The docs stated that we're appending the layer-bin path. With this change we're now prepending it to align with lifecycle.
    
    * Simplify layer_paths_come_before_manually_added_paths test
    
    * Emit scope and path on failure
    
    Before:
    
    ```
    thread 'layer_env::tests::layer_paths_come_before_manually_added_paths' panicked at libcnb/src/layer_env.rs:944:13:
    assertion `left == right` failed
      left: Some("/var/folders/yr/yytf3z3n3q336f1tj2b2j0gw0000gn/T/.tmpKPAfq0/bin:test-value")
     right: Some("test-value/var/folders/yr/yytf3z3n3q336f1tj2b2j0gw0000gn/T/.tmpKPAfq0/bin")
    ```
    
    After:
    
    ```
    thread 'layer_env::tests::layer_paths_come_before_manually_added_paths' panicked at libcnb/src/layer_env.rs:944:13:
    assertion `left == right` failed: For ENV var `PATH` scope `Build`
      left: Some("/var/folders/yr/yytf3z3n3q336f1tj2b2j0gw0000gn/T/.tmpaCmToR/bin:test-value")
     right: Some("test-value/var/folders/yr/yytf3z3n3q336f1tj2b2j0gw0000gn/T/.tmpaCmToR/bin")
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    ```
    
    * Apply suggestions from code review
    
    Co-authored-by: Manuel Fuchs <manuel.fuchs@salesforce.com>
    Signed-off-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com>
    
    ---------
    
    Signed-off-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com>
    Co-authored-by: Manuel Fuchs <manuel.fuchs@salesforce.com>
    schneems and Malax authored May 21, 2025
    Configuration menu
    Copy the full SHA
    db2676d View commit details
    Browse the repository at this point in the history
Loading
0