Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 10 commits
- 4 files changed
- 2 contributors
Commits on Apr 5, 2013
-
log: make it pass ccanlint (on Linux, at least)
1) _info example does not compile, due to missing close of function. 2) <log.h> does not exist on my system 3) You should always include your own prototypes, so include <ccan/log/log.h> 4) log_tags[] should not be defined in header, otherwise everyone who includes log.h will get their own copy, and it's unused anyway. 5) set_log_file() should take a const. 6) get_log_mode() should use modern (void) C style. 7) get_log_mode() returns an int according to the header. 8) _print_log() should mostly take const char *. 9) ccanlint wants the license mentioned in every file. There are still no tests, and there really should be! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-
Merge pull request #1 from rustyrussell/for-heshbaugh
log: make it pass ccanlint (on Linux, at least)
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master