Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 1 commit
- 1 file changed
- 1 contributor
Commits on Nov 2, 2020
-
Windows: Pass environment variables to Popen as dict of strings
In Python 3, the env argument to Popen has to be a dict of strings, see https://bugzilla.mozilla.org/show_bug.cgi?id=1585258#c4 This is important when running under Windows, where the unicode strings are processed directly by the subprocess C code. However, under posix systems the environment variables are serialized to bytes using the file system encoding, which may not support unicode characters. This means that passing bytes as environment variables and skipping the encoding is mandatory on posix in order to support unicode environment variables. Therefore skip encoding when on Windows.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master