8000 compiling with gyp · Issue #115 · haywire/haywire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

compiling with gyp #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kroggen opened this issue Jul 11, 2016 · 3 comments
Open

compiling with gyp #115

kroggen opened this issue Jul 11, 2016 · 3 comments

Comments

@kroggen
Copy link
kroggen commented Jul 11, 2016

Hi!

I could not compile with gyp on linux (arm).

It is lacking the reference to (at least) these 2 files on haywire.gyp:

          'src/haywire/http_request_buffers.c',
          'src/haywire/http_request_buffers.h',

I added these in my file and it worked.

And maybe to the pico_http_parser for those who plan to use it.

Suggestion: gyp is way smaller than cmake so it would be good to have it as default. Or at least working, as an alternative. Thank you!
@kellabyte
Copy link
Collaborator

The newly supported build is using CMake. Gyp is legacy and I should probably remove it. Use the following.

./make.sh

@kroggen
Copy link
Author
kroggen commented Jul 14, 2016

legacy? just for haywire... because it is used by many applications like node.js and Google Chrome. I had to compile cmake and it took a lot of time and use a lot of disk space.

I suggest keeping both options for those that don't like cmake.

Thank you!

@kellabyte
Copy link
Collaborator

I found maintaining a CMake based build a lot simpler and CMake is used in a lot more places. Some IDE's even support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellabyte @kroggen
0