[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore TLS version, correctly #2723

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Conversation

msimerson
Copy link
Member
@msimerson msimerson commented Oct 13, 2019

Related to: #2634, #2648, and #2708

Changes proposed in this pull request:

  • add cipher version back to header
  • this time, use the current connections version, not the minimum supported

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@msimerson msimerson changed the title restore TLS version, but correct this time restore TLS version, correctly Oct 14, 2019
@msimerson
Copy link
Member Author
msimerson commented Oct 14, 2019

<disclaimer>It's a small sample size but</disclaimer> every TLS connection that has arrived since I ported this to a production server (granted, on a slow Sunday afternoon) has been TLSv1.2.

I also wish our tls connection properties were named tls.cipher and tls.version (instead of tls.cipher.name and tls.cipher.version, but I don't want to break any existing use of them for the sake of making them a little tidier.

@msimerson
Copy link
Member Author

More data. Measured across 70,000 transactions (ie, connections that made it to at least the MAIL FROM phase of the connection:

  • TLSv1.2 = 98.2%
  • TLSv1.1 = 0.6% (just two connections, both spam, from germany and vietnam)
  • TLSv1 = 0.6% (dozens of valid connections.)

@msimerson msimerson merged commit 3b58133 into haraka:master Oct 25, 2019
@msimerson msimerson deleted the tls-version branch October 25, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant