[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPF: results store passes, es6 patterns, test improvement #2700

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

msimerson
Copy link
Member
@msimerson msimerson commented Sep 14, 2019

Changes proposed in this pull request:

  • plugins/spf: add passing domains to results.spf.pass
  • spf: es6 patterns (for...in, interpolated strings)
  • ignore temp errors in tests

Checklist:

@msimerson msimerson changed the title Spf SPF: results store passes, es6 patterns, test improvement Sep 14, 2019
@codecov
Copy link
codecov bot commented Sep 14, 2019

Codecov Report

Merging #2700 into master will increase coverage by 0.34%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2700      +/-   ##
==========================================
+ Coverage   59.71%   60.05%   +0.34%     
==========================================
  Files          29       29              
  Lines        6410     6412       +2     
  Branches     1593     1595       +2     
==========================================
+ Hits         3828     3851      +23     
+ Misses       2582     2561      -21
Impacted Files Coverage Δ
spf.js 62.14% <77.41%> (+5.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46b884...253f2ae. Read the comment docs.

- spf: es6 patterns, ignore temperrors in tests
- spf: more es6 strings
- install before lint
- ci: add github-actions workflow for coveralls
- codecov reporting from GH actions only
- better GH action names
- coveralls only on PR
@msimerson
Copy link
Member Author
msimerson commented Sep 15, 2019

Sorry to anyone that got emails every time I pushed to this branch. There was a couple dozen pushes as I futzed about with GitHub actions and workflows. Some of the things you might find interesting:

  • github actions (windows test suite) are much faster than AppVeyor
  • and slower than Travis-CI
  • click the "Show all checks" button above to see all the tests that are currently running
  • click the "Actions" tab at the top of the repo. The left pane is a dog's breakfast in there now, there's no way to clean it up yet, but you can pick a recent workflow run in the right pane and then the left pane/menu gets reduced to the current workflows.
  • GitHub Actions are still a bit rough around the edges. Good enough I intend to leave it running, but not good enough that I'm inclined to turn off AppVeyor or Travis. Yet.

@msimerson msimerson merged commit bb33740 into haraka:master Sep 16, 2019
@msimerson msimerson deleted the spf branch September 16, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant