-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump:pre is too simple #78
Comments
maybe `rake bump:pre[alpha]` etc to control the flow ?
…On Tue, Nov 7, 2017 at 2:37 AM, Benjamin Quorning ***@***.***> wrote:
The current pre-release bumping (implemented in #11
<#11>) is very naïve and not really
intuitive:
» rake bump:current
Current version: 1.2.3
» rake bump:pre
Bump version 1.2.3 to 1.2.3-alpha
» rake bump:pre
Bump version 1.2.3-alpha to 1.2.3-beta
» rake bump:pre
Bump version 1.2.3-beta to 1.2.3-rc
» rake bump:pre
Bump version 1.2.3-rc to 1.2.3
» rake bump:pre
Bump version 1.2.3 to 1.2.3-alpha
» rake bump:pre
Bump version 1.2.3-alpha to 1.2.3-beta
If you need e.g. three beta versions before moving to a release candidate,
bump is of no help.
I would prefer if repeated calls to bump:pre increased a number. Perhaps
that requires separate bump:alpha, bump:beta and bump:rc commands?
» rake bump:current
Current version: 1.2.3
» rake bump:alpha
Bump version 1.2.3 to 1.2.3-alpha1
» rake bump:alpha
Bump version 1.2.3-alpha1 to 1.2.3-alpha2
» rake bump:beta
Bump version 1.2.3-alpha2 to 1.2.3-beta1
» rake bump:rc
Bump version 1.2.3-beta1 to 1.2.3-rc1
» rake bump:rc
Bump version 1.2.3-rc1 to 1.2.3-rc2
» rake bump:rc
Bump version 1.2.3-rc2 to 1.2.3-rc3
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#78>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZx5lVN2MxyRHfq6syCRQ_BneIFeCks5s0DLPgaJpZM4QUlI7>
.
|
I think it’s possible to accomplish with colons instead of brackets, i.e. |
There are a few edge cases to consider, e.g.:
|
declare failure
…On Tue, Nov 7, 2017 at 7:57 AM, Benjamin Quorning ***@***.***> wrote:
There are a few edge cases to consider, e.g.:
» rake bump:current
Current version: 1.2.3
» rake bump:alpha
Bump version 1.2.3 to 1.2.3-alpha1
» rake bump:beta
Bump version 1.2.3-alpha1 to 1.2.3-beta1
» rake bump:alpha
… what now?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#78 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ9koT17Dzt0JCN0fbSiFnHjdEAX6ks5s0H3_gaJpZM4QUlI7>
.
|
It's also worth noting that 1.2.3-alpha is not an increase from 1.2.3. Really, in order to go from a non-pre release to a pre-release, one would need to know the eventual non-pre target. ie, if current is 1.2.3, pre-major would be 2.0.0-alpha, pre-minor would be 1.3.0-alpha, and pre-patch would be 1.2.4-alpha. Perhaps And then |
I'd also recommend that the pre-counter be dot-separated, as semver describes the pre-release version:
So 1.2.3-alpha.0 and 1.2.3-rc.4 |
Hey, I've added PR that adds new prerelease bumps here #81. Regarding applying the prerelease label to the final version (e.g. ➜ bump major --no-commit
# Bump from 1.2.3 to 2.0.0
➜ bump alpha
# Commits to git
# Bump from 2.0.0 to 2.0.0-alpha |
It might be worth following patterns that other version bumping tools follow: npm has |
Hi guys, I found this gem very useful, but you need to add the alpha, beta and rc bumps. |
bump is for "idk what version I'm on, but this is a patch"
|
The current pre-release bumping (implemented in #11) is very naïve and not really intuitive:
If you need e.g. three beta versions before moving to a release candidate,
bump
is of no help.I would prefer if repeated calls to bump:pre increased a number. Perhaps that requires separate bump:alpha, bump:beta and bump:rc commands?
The text was updated successfully, but these errors were encountered: