CMake scripts has no install() directives #1576

pkarneliuk · 2024-12-13T11:23:08Z

Since 2.16 there is no install() directives in root CMakeLists.txt. So, now it is impossible to install correct binaries by cmake tool.

cmake -S . -B "build" -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/data/tools/gperftools/2.16
cmake --build   "build" --config Release
cmake --install "build" --config Release --prefix /data/tools/gperftools/2.16

Why they were removed in 9dfab2c ?

The text was updated successfully, but these errors were encountered:

alk · 2024-12-13T18:24:27Z

Yes, cmake support is incomplete. And we openly warn people about it. It was removed because it wasn't right to confuse people into thinking that install works.

pkarneliuk · 2024-12-13T18:27:36Z

It worked perfectly in 2.15. Please revert your chages. пт, 13 дек. 2024 г., 21:24 Aliaksiej Kandracienka (aka Aliaksei Kandratsenka) ***@***.***>:

…

Yes, cmake support is incomplete. And we openly warn people about it. It was removed because it wasn't right to confuse people into thinking that install works. — Reply to this email directly, view it on GitHub <#1576 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4QQ3OYE666ZICK63GCVUL2FMQ7DAVCNFSM6AAAAABTRY4UNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBSGAYTKMJXGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

alk · 2024-12-13T18:36:00Z

Please describe "perfectly". Tests didn't pass for example. Keep in mind that "perfectly" for you isn't necessarily good enough for me.

pkarneliuk · 2024-12-16T05:36:50Z

The release 2.15 installs headers, libs, configs and binaries to requested directories.

[pkarneliuk@host]$ cmake --install "build" --config Release --prefix /data/tools/gperftools/2.15
-- Installing: /data/tools/gperftools/2.15/include/google/heap-checker.h
-- Installing: /data/tools/gperftools/2.15/include/google/heap-profiler.h
-- Installing: /data/tools/gperftools/2.15/include/google/malloc_extension.h
-- Installing: /data/tools/gperftools/2.15/include/google/malloc_extension_c.h
-- Installing: /data/tools/gperftools/2.15/include/google/malloc_hook.h
-- Installing: /data/tools/gperftools/2.15/include/google/malloc_hook_c.h
-- Installing: /data/tools/gperftools/2.15/include/google/profiler.h
-- Installing: /data/tools/gperftools/2.15/include/google/stacktrace.h
-- Installing: /data/tools/gperftools/2.15/include/google/tcmalloc.h
-- Installing: /data/tools/gperftools/2.15/bin/pprof-symbolize
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_minimal.so.9.16.5
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_minimal.so
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_minimal.a
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_minimal_debug.so.9.16.5
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_minimal_debug.so
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_minimal_debug.a
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc.so.9.16.5
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc.so
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc.a
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_debug.so.9.16.5
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_debug.so
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_debug.a
-- Installing: /data/tools/gperftools/2.15/lib64/libprofiler.so.5.11.5
-- Installing: /data/tools/gperftools/2.15/lib64/libprofiler.so
-- Installing: /data/tools/gperftools/2.15/lib64/libprofiler.a
-- Installing: /data/tools/gperftools/2.15/include/gperftools/tcmalloc.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/stacktrace.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/malloc_hook.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/malloc_hook_c.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/malloc_extension.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/malloc_extension_c.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/nallocx.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/heap-profiler.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/heap-checker.h
-- Installing: /data/tools/gperftools/2.15/include/gperftools/profiler.h
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_and_profiler.so.10.11.6
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_and_profiler.so
-- Installing: /data/tools/gperftools/2.15/lib64/libtcmalloc_and_profiler.a
-- Installing: /data/tools/gperftools/2.15/lib64/pkgconfig/libtcmalloc.pc
-- Installing: /data/tools/gperftools/2.15/lib64/pkgconfig/libtcmalloc_minimal.pc
-- Installing: /data/tools/gperftools/2.15/lib64/pkgconfig/libtcmalloc_debug.pc
-- Installing: /data/tools/gperftools/2.15/lib64/pkgconfig/libtcmalloc_minimal_debug.pc
-- Installing: /data/tools/gperftools/2.15/lib64/pkgconfig/libprofiler.pc
[pkarneliuk@host gperftools]$

The libraries have symbolic links with versions.

[pkarneliuk@host gperftools]$ ls -la /data/tools/gperftools/2.15/lib64/
total 4628
drwxr-xr-x 3 sfxrunner sfxrunner   4096 Sep 12 01:05 .
drwxr-xr-x 5 sfxrunner sfxrunner     62 Sep 12 01:11 ..
-rw-r--r-- 1 sfxrunner sfxrunner  91158 Sep 12 01:04 libprofiler.a
lrwxrwxrwx 1 sfxrunner sfxrunner     21 Sep 12 01:05 libprofiler.so -> libprofiler.so.5.11.5
-rwxr-xr-x 1 sfxrunner sfxrunner  79096 Sep 12 01:03 libprofiler.so.5.11.5
-rw-r--r-- 1 sfxrunner sfxrunner 620710 Sep 12 01:04 libtcmalloc.a
-rw-r--r-- 1 sfxrunner sfxrunner 674482 Sep 12 01:03 libtcmalloc_and_profiler.a
lrwxrwxrwx 1 sfxrunner sfxrunner     35 Sep 12 01:05 libtcmalloc_and_profiler.so -> libtcmalloc_and_profiler.so.10.11.6
-rwxr-xr-x 1 sfxrunner sfxrunner 413352 Sep 12 01:03 libtcmalloc_and_profiler.so.10.11.6
-rw-r--r-- 1 sfxrunner sfxrunner 697038 Sep 12 01:04 libtcmalloc_debug.a
lrwxrwxrwx 1 sfxrunner sfxrunner     27 Sep 12 01:05 libtcmalloc_debug.so -> libtcmalloc_debug.so.9.16.5
-rwxr-xr-x 1 sfxrunner sfxrunner 424288 Sep 12 01:03 libtcmalloc_debug.so.9.16.5
-rw-r--r-- 1 sfxrunner sfxrunner 430784 Sep 12 01:03 libtcmalloc_minimal.a
-rw-r--r-- 1 sfxrunner sfxrunner 419962 Sep 12 01:03 libtcmalloc_minimal_debug.a
lrwxrwxrwx 1 sfxrunner sfxrunner     35 Sep 12 01:05 libtcmalloc_minimal_debug.so -> libtcmalloc_minimal_debug.so.9.16.5
-rwxr-xr-x 1 sfxrunner sfxrunner 263672 Sep 12 01:03 libtcmalloc_minimal_debug.so.9.16.5
lrwxrwxrwx 1 sfxrunner sfxrunner     29 Sep 12 01:05 libtcmalloc_minimal.so -> libtcmalloc_minimal.so.9.16.5
-rwxr-xr-x 1 sfxrunner sfxrunner 205152 Sep 12 01:03 libtcmalloc_minimal.so.9.16.5
lrwxrwxrwx 1 sfxrunner sfxrunner     21 Sep 12 01:05 libtcmalloc.so -> libtcmalloc.so.9.16.5
-rwxr-xr-x 1 sfxrunner sfxrunner 386304 Sep 12 01:04 libtcmalloc.so.9.16.5
drwxr-xr-x 2 sfxrunner sfxrunner    144 Sep 12 01:05 pkgconfig

Why this functionality was removed?

alk · 2024-12-16T16:58:46Z

Again, tests were not passing. It wasn't right in many ways. E.g. so versions were bogus. That you see some files in plausibly looking places doesn't mean everything works and is in shape that makes it possible for me to support it.

Simply reverting is not possible. That is 100%.

You should be using autotools-based means to build and install gperftools. It is officially supported.

If you're one of cmake enthusiasts, consider helping for example here: #1575 (even then I cannot make any hard promises; it is me who will have to support this stuff)

pkarneliuk · 2024-12-16T17:01:55Z

First, point me to these failed tests. Second, tell me how copying files can affect your tests. пн, 16 дек. 2024 г., 19:59 Aliaksiej Kandracienka (aka Aliaksei Kandratsenka) ***@***.***>:

…

Again, tests were not passing. It wasn't right in many ways. E.g. so versions were bogus. That you see some files in plausibly looking places doesn't mean everything works and is in shape that makes it possible for me to support it. Simply reverting is not possible. That is 100%. You should be using autotools-based means to build and install gperftools. It is officially supported. If you're one of cmake enthusiasts, consider helping for example here: #1575 <#1575> (even then I cannot make any hard promises; it is me who will have to support this stuff) — Reply to this email directly, view it on GitHub <#1576 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4QQ3IMLZXMRNXAUS73L732F4BF3AVCNFSM6AAAAABTRY4UNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBWGE2TQOJRHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

alk · 2024-12-16T17:08:27Z

Just above you posted how you used 2.15 to do equivalent of make install. You should be able to do equivalent of make check.

(I am putting my responses to this ticket into throttling mode to reduce the risk of sending impolite replies; don't expect timely responses)

pkarneliuk · 2024-12-16T17:11:37Z

1. Failed tests, please 2. Your explanation, how it is related to install() directives пн, 16 дек. 2024 г., 20:08 Aliaksiej Kandracienka (aka Aliaksei Kandratsenka) ***@***.***>:

…

Just above you posted how you used 2.15 to do equivalent of make install. You should be able to do equivalent of make check. (I am putting my responses to this ticket into throttling mode to reduce the risk of sending impolite replies; don't expect timely responses) — Reply to this email directly, view it on GitHub <#1576 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4QQ3OV36CDUSUJ3UVRVUT2F4CKFAVCNFSM6AAAAABTRY4UNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBWGE4DAMRXGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

alk · 2024-12-16T17:57:09Z

Lets calm down a bit. Keep in mind that I owe you nothing and you owe me nothing as well.

From what I see, you're messages are indistinguishable from some troll trying to waste my time, demanding me "to explain myself" without any attempt to do own homework. All the answers you seek are in code or git history.

If you came here to argue, then this is going nowhere. If you're serious about helping then help. Talk is cheap. Show me the code.

pkarneliuk changed the title ~~CMake scripts has not install() directives~~ CMake scripts has no install() directives Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMake scripts has no install() directives #1576

CMake scripts has no install() directives #1576

CMake scripts has no install() directives #1576

CMake scripts has no install() directives #1576

Comments