8000 Repository Pattern · Issue #165 · gothinkster/realworld · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Repository Pattern #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tjhunkin opened this issue Jan 3, 2018 · 4 comments
Closed

Repository Pattern #165

tjhunkin opened this issue Jan 3, 2018 · 4 comments

Comments

@tjhunkin
Copy link
tjhunkin commented Jan 3, 2018

Looking at the nodejs implementation, for example, the controllers are very messy with large functions. It's better practice to shift the code into a separate area rather than shoving it all into the controller. In a larger project, the controllers can get extremely bloated.

I understand that this project is to demonstrate implementations, but it'll be better to teach new guys and gals better principles.
@Cameron-C-Chapman
Copy link
Member

@tjhunkin I agree that best practices are ideal for any of the realworld projects but those best practices can differ quite a bit between the languages/frameworks. We rely on a review process for each project specific to members of that community to help determine if the project is a good representative. It would be really hard to enforce best practices architecturally for such varied code bases.

Does this feel like something that would be better addressed in the individual repos or maybe an improvement to our review process?

@tjhunkin
Copy link
Author
tjhunkin commented Jan 9, 2018

I think it should be a standard to separate the code out. Based on this comment and your comment on the database consistency issue, it seems that we're not on the same page. I will refrain from any further comments due to the futility.

@Cameron-C-Chapman
Copy link
Member
Cameron-C-Chapman commented Jan 9, 2018 •
edited
Loading

I don't think it's futile or that you need to refrain from submitting questions and ideas @tjhunkin, I'm just giving you my personal opinio 8000 n but I'm just one opinion.

@gothinkster/realworld-admins any other thoughts on this and/or #164? I think these kind of requirements would be misplaced at the realworld requirement level and make more sense at the individual repo level to be required during the RFC process.

@EricSimons
Copy link
Member

@tjhunkin I appreciate you imparting feedback on this project but please refrain from insulting our community members.

From a purely technical point of view, I agree that many of these implementations could use some reorganization/refactoring/etc. However, these codebases are intentionally designed to be beginner friendly per the 'golden rule' in our spec/guidelines: keep the codebases simple yet robust.

If you have comments about how specific implementations can be improved (i.e. node), feel free to open up an issue and/or PR on that repo specifically 👍

@elcobvg elcobvg mentioned this issue Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EricSimons @Cameron-C-Chapman @tjhunkin
0