8000 encoding/gob: misleading error message for maps with NaN keys · Issue #24075 · golang/go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

encoding/gob: misleading error message for maps with NaN keys #24075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Feb 23, 2018 · 1 comment
Closed

encoding/gob: misleading error message for maps with NaN keys #24075

bcmills opened this issue Feb 23, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor
bcmills commented Feb 23, 2018 •
edited
Loading

The encoding/gob package emits an erroneous error message when attempting to encode a map containing irreflexive keys (such as math.NaN()):
https://play.golang.org/p/QgRVchmloT6

The error message it returns is gob: encodeReflectValue: nil element, but encodeReflectValue is not part of the exported or documented API, and there are no nil elements involved.

Ideally, encoding/gob should correctly handle maps with irreflexive keys. That would likely require either a fix for #11104, or a change to map lookups to use representation equivalence instead of == (per #20660 (comment)).

If it isn't feasible for gob to handle irreflexive map keys, that restriction should be documented in the gob package, and the errors that gob methods return should describe the correct problem.

This issue parallels #14427.
@bcmills bcmills mentioned this issue Feb 23, 2018
Open
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 28, 2018
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Mar 28, 2018
@bcmills bcmills mentioned this issue Dec 16, 2020
Closed
@seankhliao seankhliao mentioned this issue Jul 30, 2021
Closed
@korzhao korzhao mentioned this issue Jul 30, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/338609 mentions this issue: encoding/gob: marshal maps using reflect.Value.MapRange

@bcmills bcmills modified the milestones: Unplanned, Go1.18 Aug 5, 2021
@golang golang locked and limited conversation to collaborators Sep 7, 2022
@julieqiu julieqiu removed this from Go Security Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

Successfully merging a pull request may close this issue.

encoding/gob: marshal maps using reflect.Value.MapRange
3 participants
@ianlancetaylor @bcmills @gopherbot
0