8000 random functions in test should use Rand · Issue #121 · golang/geo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

random functions in test should use Rand #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmr opened this issue Mar 20, 2025 · 0 comments
Open

random functions in test should use Rand #121

jmr opened this issue Mar 20, 2025 · 0 comments
Assignees
@rsned

Comments

@jmr
Copy link
Collaborator
jmr commented Mar 20, 2025

Tests should pass a Rand around instead of depending on global state.

geo/s2/s2_test.go

Line 56 in 69a8a98

func randomBits(num uint32) uint64 {

C++ was changed to do this a while ago.
@rsned rsned self-assigned this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsned rsned

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmr @rsned
0