8000 The autohint script uses `os.rename` to do file move on Windows · Issue #1097 · googlefonts/gftools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

The autohint script uses os.rename to do file move on Windows #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CrendKing opened this issue Apr 26, 2025 · 0 comments · Fixed by #1099
Closed

The autohint script uses os.rename to do file move on Windows #1097

CrendKing opened this issue Apr 26, 2025 · 0 comments · Fixed by #1099

Comments

@CrendKing
Copy link

Looks like another OS compatibility issue like #1096. If I understand correctly, the autohint script aims to be able to overwrite the input file with the autohinted output so user doesn't have to do the rename dance. It achieves this with a os.rename at the end. Unfortunately, os.rename doesn't work on Windows if the target exists. Like the Python doc suggests, maybe replace with shutil.move for better compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make some scripts more cross-platform googlefonts/gftools
1 participant
@CrendKing
0