8000 We should release our policy types · Issue #9434 · googleapis/google-cloud-cpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
We should release our policy types #9434
Closed
@dbolduc

Description

@dbolduc

We define policy types like this:

using AccessApprovalRetryPolicy =
::google::cloud::internal::TraitBasedRetryPolicy<
accessapproval_internal::AccessApprovalRetryTraits>;

This is in violation of https://github.com/googleapis/google-cloud-cpp/blob/main/doc/adr/2022-01-21-only-public-types-in-public-APIs.md

There is no way to learn the interface of this type, other than by looking at the code. (Doxygen does not generate documentation for internal::TraitBasedRetryPolicy<T>)

To allow for customer-defined retry policies, I think we need to release RetryPolicy and TraitBasedRetryPolicy.

Metadata

Metadata

Assignees

Labels

type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0