8000 Support dense attributes in mod_arith constant folding and canonicalization · Issue #1759 · google/heir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support dense attributes in mod_arith constant folding and canonicalization #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
j2kun opened this issue Apr 23, 2025 · 1 comment
Open

Support dense attributes in mod_arith constant folding and canonicalization #1759

j2kun opened this issue Apr 23, 2025 · 1 comment

Comments

@j2kun
Copy link
Collaborator
j2kun commented Apr 23, 2025

Currently it only supports scalars, but the mod_arith.constant op is elementwise and has uses now that involve dense attributes. Also cf. #1758 since if/when that lands it will greatly simplify the work. Before that PR, one will need to ensure the attributes passed along the folding chain use an underlying integer type (IntegerAttr or DenseIntElementsAttr) corresponding to the modulus storage type. After that PR, one should be able to just use a DenseIntElementsAttr that is typed as a tensor of ModArith types.
@j2kun j2kun changed the title Support dense attributes in mod_arith constant folding Support dense attributes in mod_arith constant folding and canonicalization Apr 23, 2025
@j2kun j2kun mentioned this issue Apr 23, 2025
Merged
@github-actions GitHub Actions
Copy link

This issue has 4 outstanding TODOs:

This comment was autogenerated by todo-backlinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j2kun
0