8000 [CMake] sanitizer is forced to "address sanitizer" · Issue #1124 · google/fuzztest · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
[CMake] sanitizer is forced to "address sanitizer" #1124
New issue
New issue
Open
Open
[CMake] sanitizer is forced to "address sanitizer"#1124
@vrabaud

Description

@vrabaud
vrabaud
opened on Apr 9, 2024

In fuzzing mode or compatibility mode, address sanitizer is forced.

fuzztest/cmake/FuzzTestFlagSetup.cmake 58D2

Lines 2 to 3 in a990537

if (FUZZTEST_FUZZING_MODE OR (FUZZTEST_COMPATIBILITY_MODE STREQUAL "libfuzzer"))
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -UNDEBUG -fsanitize=address")

This is problematic on oss-fuzz which has different sanitizers. We therefore remove those flags https://github.com/AOMediaCodec/libavif/blob/d074bae4b0b1d7423d102f6d9d5e0c5303971a51/ext/fuzztest.cmd#L14 and use the ones set in the environment variable CXXFLAGS by oss-fuzz.

I believe those sanitizer flags should only be set for FUZZTEST_FUZZING_MODE, not when FUZZTEST_COMPATIBILITY_MODE STREQUAL "libfuzzer").

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0