8000 Tests are broken due to ID changes · Issue #525 · google/blockly-keyboard-experimentation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tests are broken due to ID changes #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
BenHenning opened this issue May 15, 2025 · 2 comments · Fixed by #527
Closed
1 task done

Tests are broken due to ID changes #525

BenHenning opened this issue May 15, 2025 · 2 comments · Fixed by #527
Assignees
@BenHenning

Comments

@BenHenning
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

Most tests are failing on tip-of-tree:

Starting webdriverio...
  Keyboard navigation on Blocks
    ✔ Default workspace
    1) Selected block
    2) Down from statement block selects next block across stacks
    3) Up from statement block selects previous block
    4) Down from parent block selects first child block
    5) Up from child block selects parent block
    ✔ Right from block selects first field (210ms)
    6) Right from block selects first inline input
    7) Up from inline input selects statement block
    8) Left from first inline input selects block
    9) Right from first inline input selects second inline input
    10) Left from second inline input selects first inline input
    11) Right from last inline input selects next block
    12) Down from inline input selects next block
    13) Down from inline input selects block's child block
    14) Right from text block selects shadow block then field

  Keyboard navigation on Fields
    15) Up from first field selects block
    16) Left from first field selects block
    ✔ Right from first field selects second field (212ms)
    ✔ Left from second field selects first field (226ms)
    17) Right from second field selects next block
    18) Down from field selects next block
    19) Down from field selects block's child block

  Clipboard test
    ✔ Copy and paste while block selected (255ms)
    ✔ Cut and paste while block selected (780ms)
    ✔ Copy and paste whilst dragging block (443ms)
    ✔ Cut whilst dragging block (427ms)

  Insert test
    ✔ Insert C-shaped block with statement block selected (408ms)

Reproduction steps

  1. Check out 8a9e9d9.
  2. Ensure that it's updated to use v12 beta.7 and has been correctly npm install'd and npm ci'd.
  3. Run npm run test.
  4. Observe the failures.

Stack trace

There are a bunch (one for each failing test), and here's one example:


  19) Keyboard navigation on Fields
       Down from field selects block's child block:

      AssertionError: expected 'blockly-1p' to equal 'draw_emoji_1'
      + expected - actual

      -blockly-1p
      +draw_emoji_1

      at Context.<anonymous> (file:///usr/local/google/home/bhenning/opensource/blockly-keyboard-experimentation/test/webdriverio/test/dist/basic_test.js:316:18)
      at Generator.next (<anonymous>)
      at fulfilled (file:///usr/local/google/home/bhenning/opensource/blockly-keyboard-experimentation/test/webdriverio/test/dist/basic_test.js:9:58)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Screenshots

None.

Browsers

No response
@BenHenning BenHenning self-assigned this May 15, 2025
@BenHenning
Copy link
Contributor Author
BenHenning commented May 15, 2025 •
edited
Loading

I'm sure this was caused by google/blockly#9045 since it changes the main ID used for BlockSvg's focusable element, and keyboard navigation tests depend on that ID for verification:

blockly-keyboard-experimentation/test/webdriverio/test/test_setup.ts

Lines 233 to 235 in 8a9e9d9

return Blockly.getFocusManager().getFocusedNode()?.getFocusableElement()
?.id;
});

/cc @rachel-fenichel who found this and mentioned it to me over chat.

I forgot to run the keyboard navigation tests as part of checking my PR. :(

This was referenced May 15, 2025
Merged
Merged
@BenHenning
Copy link
Contributor Author

There's also one new failure in 12.0.0 over beta.7 due to google/blockly#9054 (see #527 (comment)).

@BenHenning BenHenning mentioned this issue May 15, 2025
Merged
1 task
@maribethb maribethb moved this to In Progress in Blockly Accessibility May 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Blockly Accessibility May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
None yet
Projects
Blockly Accessibility
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Broken tests + upgrade to Blockly 12.0.0. BenHenning/blockly-keyboard-experimentation
2 participants
@maribethb @BenHenning
0