Description
#9154 added Escape and Cmd/Ctrl+Enter shortcuts to move focus from a workspace comment textarea to the comment, allowing you to get out of the text area.
However, they only work for comments that have been focused (the comment itself, not the text area).
Repro:
- Click in an existing workspace comment textarea or even tab into the textarea, e.g. via this demo
- Press escape or Cmd+Enter
- Nothing happens, focus is still on the text area
Cause: The keydown handler calls this.svgRoot.focus() but at this point the SVG root is a <g> element without a tabindex so cannot be focused. New comment or comments you've clicked on have tabindex=-1 so those cases work.
Ideally this would be fixed in the context of a broader plan for keyboard navigation of comments that e.g. eliminates the comment tab stops in favour of navigation more similar to block navigation (at least when using the keyboard nav plugin). But providing some route back to blocks once you've moved to a comment is also important.
Metadata
Metadata
Assignees
Type
Projects
Status