maxInstance fix #5430
maxInstance fix #5430
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
There was a problem hiding this comment.
Hi @Apoorvgarg-creator ! This fix looks great. Thank you for putting this PR up and filling out the description. Seeing what you did to test was really helpful for reviewing this PR =)
I left a comment with one little code simplification, but otherwise LGTM! Once that's fixed I'll get this merged.
Co-authored-by: Beka Westberg <bekawestberg@gmail.com>
The basics
The details
Resolves
Issue Fix #5374
Proposed Changes
This PR fixes the issue #5374, Filtering out the insertion marker in the function getsBlockByType will fix the issue.
Behavior Before Change
As @kvanthienen stated-
When the maxInstances option is set for a block (for example to 5), the corresponding block in the toolbox gets the 'blocklyDisabled' class after all the instances have been used in the workspace as expected.
The strange thing, however, is that this block already temporarily gets the 'blocklyDisabled' status while dragging around the second-last block on the workspace (for example block number 4). When the block is released, the status is flipped again.
Behavior After Change
This is a short term fix where blocks which are not real
Insertion markerare filtered out. Hence, on dragging the block it is not counted twice.Thus solving the issue when Maxinstance is reached when the block haven't placed yet.Screen.Recording.2021-09-06.at.8.55.53.AM.mov
Reason for Changes
Whenever we were picking a block set with a maxInstance, getsBlockByType returns the value with insertion marker + number of blocks, which was causing the problem as an virtual object
(Insertion marker)got counted as well as.So filtering out insertion marker gives the correct count.
Test Coverage
Tested on:
Documentation
No changes in documentation
@BeksOmega