Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 14 commits
- 8 files changed
- 3 contributors
Commits on Jul 4, 2024
Commits on Jul 15, 2024
-
Avoid breakages for WITH_LLVM builds with libprotobuf < 3.19.0 (#200)
Recent commit 623c777 introduced spe_tid_pid_provider, which includes `repeated_ptr_field.h` (`RepeatedPtrField` was only moved to its own header in 3.19.0). `repeated_field.h` transitively includes `repeated_ptr_field` in new versions of libprotobuf for backwards compatibility reasons, so we can include that instead.
Commits on Jul 16, 2024
-
Fixed testcase failures when build directory is not under the source …
…directory. "../testdata" assumes the build directory is inside the source directory, which is not always true. Fixed this by using the source directory explicitly.
-
Merge pull request #206 from shenhanc78/dev_branch_2
Fixed testcase failures when build directory is not under the source directory
-
Fix compilation error when building using github build bot.
GCC used in the bot is Ubuntu 22.04 - gcc 11.4.0, the error was (buildbot log: https://github.com/google/autofdo/actions/runs/9962415417/job/27526112613) Tested: buildbot build passed clang / (newer) gcc build passed on my workstation /home/runner/work/autofdo/autofdo/llvm_propeller_cfg_test.cc: In member function ‘virtual void devtools_crosstool_autofdo::{anonymous}::LlvmPropellerCfg_CloneCfg_Test::TestBody()’: /home/runner/work/autofdo/autofdo/llvm_propeller_cfg_test.cc:179:34: error: call of overloaded ‘CfgInterEdgesMatcher(<brace-enclosed initializer list>)’ is ambiguous 179 | CfgInterEdgesMatcher({})))); | ^ In file included from /home/runner/work/autofdo/autofdo/llvm_propeller_cfg_test.cc:6: /home/runner/work/autofdo/autofdo/llvm_propeller_cfg_matchers.h:154:12: note: candidate: ‘devtools_crosstool_autofdo::CfgInterEdgesMatcher::CfgInterEdgesMatcher(absl::lts_20240116::Span<const testing::Matcher<devtools_crosstool_autofdo::CFGEdge> >)’ 154 | explicit CfgInterEdgesMatcher( | ^~~~~~~~~~~~~~~~~~~~ /home/runner/work/autofdo/autofdo/llvm_propeller_cfg_matchers.h:148:7: note: candidate: ‘devtools_crosstool_autofdo::CfgInterEdgesMatcher::CfgInterEdgesMatcher(const devtools_crosstool_autofdo::CfgInterEdgesMatcher&)’ 148 | class CfgInterEdgesMatcher { | ^~~~~~~~~~~~~~~~~~~~ /home/runner/work/autofdo/autofdo/llvm_propeller_cfg_matchers.h:148:7: note: candidate: ‘devtools_crosstool_autofdo::CfgInterEdgesMatcher::CfgInterEdgesMatcher(devtools_crosstool_autofdo::CfgInterEdgesMatcher&&)’ [ 64%] Building CXX object third_party/llvm-project/llvm/lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPass.cpp.o make[2]: Leaving directory '/home/runner/work/autofdo/autofdo/build' make[2]: *** [CMakeFiles/llvm_propeller_cfg_test.dir/build.make:76: CMakeFiles/llvm_propeller_cfg_test.dir/llvm_propeller_cfg_test.cc.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:6254: CMakeFiles/llvm_propeller_cfg_test.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs....
-
Commits on Jul 17, 2024
-
Merge pull request #210 from google/shenhanc78_dev_branch_2
Fix compilation error when building using github build bot.
-
Removed WITH_LLVM and replaced protobuf_generate_cpp with more modern…
… protobuf_generate (#199) * AA * Pretty-format the patch. * Explicitly add PROTOBUF include dir to target inclusion dir. When PROTOBUF is not installed in the system inclusion dir (e.g., it is built from a source tree and installed locally), the build will fail. Added "${PROTOBUF_INCLUDE_DIR}" to target_include_directories will fix this. * Added back gcc tools build. * Pretty formatted. * Force LLVM to use ZSTD. * Removed last commit because of wrong author. * Revert "Pretty formatted." This reverts commit 1c0b5f0. * USE "ENABLE_TOOL=GCOV|LLVM" to control which tool to build. Defaults to LLVM. * Refined README doc. * Dropped gcc/clang version suffix in README
-
Fix format/indention error in README. (#212)
* Fix format/indention error in README. * Removed lingering g++-9 references.
Commits on Jul 18, 2024
-
Add a config to build and run on PRs. (#213)
Currently the CI config targets 22.04 with tests being run for the LLVM tools built with clang. We also build GCOV tools built with GCC but do not test them yet since a couple of tests are failing. Also fix the commit hash check.
-
We shouldn't checkout v0.20.1 since it doesn't include the latest changes to the CMakeLists such as ENABLE_TOOL.
Commits on Jul 20, 2024
-
Add a workflow to create release build (#217)
This CL setup a workflow to create a release build. Below is the steps to create a release: 1. submit all changes to master branch 2. create a RELEASE.md file under the root directory, the "RELEASE.md" can be created via github's draft new release text page 3. submit RELEASE.md to master branch 4. create a release tag, a release tag is like "v[0-9]+.[0-9]+.[0-9]+", this can be done locally: git tag <tag_name> 5. push the tag: git push <repo> tag <tag_name> 6. the work flow will be triggered This workflow can also be manually triggered to create a release for older versions. The workflow shall be further improved so that we can create the release on the github webpage and let it trigger the release build. * Add a workflow to create relase build. * Addressed review comments. * Use clang/clang++ to build release binaries.
Commits on Jul 22, 2024
-
Build full-static LLVM tools binaries (#216)
* Build static llvm tool binaries. Previously, the binaries built when ENABLE_TOOL=LLVM are all dynamically linked, there are many .so dependencies that prevent the tool binaries from be deployed to other systems. The change is also required when building release binaries. * Disable gflags and unwind for glog. * Added comments. * Re-enable zlib. * Updated comment. * Make all llvm tools static executable binaries by adding "-static" to the linking command.
-
Create RELEASE.md for v0.30 (#218)
* Create RELEASE.md for v0.30 * Removed "## New Contributors" section.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.20.1...v0.30