8000 Smart links to other issues and PRs are not generated anymore (>= 0.12) · Issue #6506 · gogs/gogs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Smart links to other issues and PRs are not generated anymore (>= 0.12) #6506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WuShell opened this issue Feb 23, 2021 · 7 comments · Fixed by #6723
Closed

Smart links to other issues and PRs are not generated anymore (>= 0.12) #6506

WuShell opened this issue Feb 23, 2021 · 7 comments · Fixed by #6723
Assignees
@unknwon
Labels
💊 bug Something isn't working

Comments

@WuShell
Copy link
WuShell commented Feb 23, 2021

Describe the bug

Generation of (smart) links to issues and PRs don't work in versions higher than 0.12.

Gogs version and commit

Tried with 0.12.3 (several instances, different servers) and 0.13.0-dev

It happens also in https://try.gogs.io (see attached screenshots)

Git version

$ git version
git version 2.30.1

Operating system

FreeBSD, Debian

Database

PostgreSQL 11, MySQL 5.5

To Reproduce
Steps to reproduce the behavior:

  1. open an issue, in the description write the number of another issue, like Users sign in/out #2
  2. click on preview, in the rendered preview, Users sign in/out #2 is a link to issue number 2
  3. click save, in the rendered page with the new issue, Users sign in/out #2 is not a link to issue number 2

Can you reproduce the bug at https://try.gogs.io?

Yes

https://try.gogs.io/14mroot/testing-issue/issues/2

Expected behavior

Write #{issue} and a link to the issue to be rendered

Actual behavior

Wrote #{issue} and a link to the issue is not rendered

Screenshots

Attached are three screenshots with the described behaviour in try.gogs.io
gogs-report-1
gogs-report-2
gogs-report-3

Additional context
@oscarmlage
Copy link
oscarmlage commented Feb 23, 2021 •
edited
Loading

Same here too. 0.13.0-dev on Docker + MySQL. Preview is working but then when publishing the comment I don't get the link to the issue.

  • Application version → 0.13.0+dev
  • Git version → 2.24.3
  • Go version → go1.14.7
  • Build datetime → 2020-12-13 02:27:53 UTC
  • Build commit → af6510f

@jjakob
Copy link
jjakob commented May 4, 2021

I'm having the same issue on 0.12.3.

8000

@oscarmlage
Copy link

Experiencing same issue even in current try.gogs.io:

If I put #2 as reference to the issue n. 2 it's not working, it only works if I write [#2](/issues/2).

@unknwon unknwon added the 💊 bug Something isn't working label Jan 13, 2022
@unknwon unknwon changed the title (Smart) Links to other issues and PRs are not generated anymore (>= 0.12) Smart links to other issues and PRs are not generated anymore (>= 0.12) Jan 13, 2022
@unknwon
Copy link
Member
unknwon commented Jan 13, 2022 •
edited
Loading

Thanks for reporting! I'm going to take a look (only prioritized, no commitment) as it seems should be easy to fix, and e6b4c46 might be suspicious.

@unknwon unknwon mentioned this issue Jan 13, 2022
Merged
3 tasks
@unknwon unknwon linked a pull request Jan 13, 2022 that will close this issue
markup: use default link formation when no format in metas #6723
Merged
3 tasks
@unknwon unknwon self-assigned this Jan 13, 2022
@unknwon
Copy link
Member
unknwon commented Jan 13, 2022 •
edited
Loading

This issue should be fixed in #6723, and I'm cherry-picking to release/0.12 branch so it will be released along with the next patch release, which I'm planning to do it this weekend (no commitment).

@oscarmlage
Copy link

Thank you so much @unknwon!

@unknwon
Copy link
Member
unknwon commented Jan 18, 2022

The 0.12.4 has been released that includes the patch of the reported issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@unknwon unknwon

Labels
💊 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

markup: use default link formation when no format in metas gogs/gogs
4 participants
@oscarmlage @WuShell @unknwon @jjakob
0