8000 Comparing v0.2.0...v0.3.0 · go-logfmt/logfmt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-logfmt/logfmt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.0
Choose a base ref
...
head repository: go-logfmt/logfmt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 14 commits
  • 8 files changed
  • 4 contributors

Commits on May 14, 2016

  1. Add TravisCI builds.

    ChrisHines committed May 14, 2016
    Configuration menu
    Copy the full SHA
    fe0e5f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10c314f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66fa38b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    caee5a0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c9a6162 View commit details
    Browse the repository at this point in the history
  6. Add coveralls badge.

    ChrisHines committed May 14, 2016
    Configuration menu
    Copy the full SHA
    538518f View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2016

  1. Pool buffers for quoted strings and byte slices

    This reduces allocations when writing multiple quoted
    strings or byte slices, by reusing bytes.Buffers, giving
    a nice little speed up.
    
    name            old time/op    new time/op    delta
    EncodeKeyval-8     635ns ± 2%     593ns ± 0%   -6.52%  (p=0.008 n=5+5)
    
    name            old alloc/op   new alloc/op   delta
    EncodeKeyval-8      176B ± 0%       64B ± 0%  -63.64%  (p=0.008 n=5+5)
    
    name            old allocs/op  new allocs/op  delta
    EncodeKeyval-8      5.00 ± 0%      4.00 ± 0%  -20.00%  (p=0.008 n=5+5)
    nussjustin committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    389ef9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e11237 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from nuss-justin/buffer-pool

    Pool buffers for quoted strings and byte slices
    ChrisHines committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    d432719 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2016

  1. golint cleanup

    judwhite committed Nov 14, 2016
    Configuration menu
    Copy the full SHA
    9b7959f View commit details
    Browse the repository at this point in the history
  2. add failing tests

    judwhite committed Nov 14, 2016
    Configuration menu
    Copy the full SHA
    282c134 View commit details
    Browse the repository at this point in the history
  3. fuzz:

    - for parse/write/parse check, change second parse to parse the write
      of the parsed value instead of the original input
    
    encode:
    - invalidKeyRune: treat utf8.RuneError as invalid rune
    - add invalidKey, invalidKeyString funcs
      - checks len(key) == 0, invalidKeyRune, and utf8.Valid
    - needsQuotedValueRune: if value contains utf8.RuneError quote the
      value. a literal k=\ufffd encodes to k=\"\\ufffd\"
    - writeStringValue, writeBytesValue: quote any invalid utf8 string
    - the above two changes fix the "reserialized data does not match"
      error found during fuzz testing
    
    decode:
    - reject invalidKey as parse error
    
    jsonstring:
    - remove "&& size == 1" when checking for rune decode error
    
    fuzz testing output:
    - .quoted:
      "0=\"\xbd\x00\""
    - .output:
      panic: reserialized data does not match:
      "0=\"\\ufffd\\u0000\"\n"
      "0=\"�\\u0000\"\n"
    judwhite committed Nov 14, 2016
    Configuration menu
    Copy the full SHA
    52e29b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2016

  1. apply review feedback

    judwhite committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    a9a71ce View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4 from judwhite/feature/fuzz

    Fuzz fix, quote invalid UTF-8 values
    ChrisHines authored Nov 15, 2016
    Configuration menu
    Copy the full SHA
    390ab79 View commit details
    Browse the repository at this point in the history
Loading
0