8000 Missing SSH public keys from LDAP · Issue #14849 · go-gitea/gitea · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Missing SSH public keys from LDAP #14849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8000
strk opened this issue Mar 2, 2021 · 5 comments
Closed

Missing SSH public keys from LDAP #14849

strk opened this issue Mar 2, 2021 · 5 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@strk
Copy link
Member
strk commented Mar 2, 2021

I'm still having trouble with public ssh keys synchronization from LDAP.
I have added 4 sshPublicKey in LDAP but only see 2 in Gitea.

One thing I noticed is that 3 of those 4 keys I have in LDAP all start with the same list of characters, and the portion of the key shown by Gitea is the start of such "common substring". Maybe Gitea is just assuming the keys are EQUAL due to this shared initial string ? The keys are of ecdsa-sha2-nistp521 type and the first character outside the substring shown by Gitea is a b (not found before).

It would help if Gitea showed the whole key somehow, or at least the key comment at the end, to know what it's taking in consideration.

Gitea Version: 1.12.3
@strk
Copy link
Member Author
strk commented Mar 2, 2021

Sorry, I was misleaded by the need to logout/login again to see changes done in LDAP.
Now that I did I realize that with the given version of Gitea, only a SINGLE key is retrieved from LDAP when there are multiple ones.

Sounds like a revival of #13984 but I cannot find traces of the fix for that one in the CHANGELOG.md file. @zeripath any idea bout that ? Could you figure that out and add to CHANGELOG in the appropriate section ?

@strk
Copy link
Member Author
strk commented Mar 2, 2021

Logs from Gitea, about the "common substring":

2021/03/02 01:54:15 models/user.go:1746:addLdapSSHPublicKeys() [E] addLdapSSHPublicKeys[OSGeo LDAP]: Error adding LDAP Public SSH Key for user strk: public key already exists [owner_id: 2, name: OSGeo LDAP-ecdsa-sha2-nistp521 AAAAE2VjZHNhLXNoYTIt]

@strk
Copy link
Member Author
strk commented Mar 2, 2021

Another problem (needs another ticket?) is that even if I enter a single key, ecdsa-sha2-nistp521 typed ssh key seems not supported (rsa works)

@zeripath
Copy link
Contributor
zeripath commented Mar 2, 2021

Gitea Version: 1.12.3 <- do you mean 1.13.2 or 1.12.3?

@zeripath zeripath added the issue/duplicate The issue has already been reported. label Mar 2, 2021
@zeripath
Copy link
Contributor
zeripath commented Mar 2, 2021

#13989 and #14607 are not in a released version of Gitea yet and they won't go in to 1.12. #14607 will be in 1.13.3 when it is released.

Please re-test on release/v1.13 or master. I'm closing as duplicate please reopen if this remains true on release/v1.13 or v1.13.3 when it is released.

Duplicate #13984

@zeripath zeripath closed this as completed Mar 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@strk @zeripath
0