8000 Cannot show more than 100 replies to a single comment · Issue #32 · giscus/giscus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cannot show more than 100 replies to a single comment #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
laymonage opened this issue May 5, 2021 · 1 comment
Open

Cannot show more than 100 replies to a single comment #32

laymonage opened this issue May 5, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@laymonage
Copy link
Member
laymonage commented May 5, 2021 •
edited
Loading

We useSWRInfinite to implement cursor-based pagination. However, we need nested pagination in order to show more than 100 replies (the limit) to a comment. I haven't found an "easy" way to implement it with SWR. The key is to handle SWR key (heh) elegantly so that it can keep track of the pages correctly.

Thus, we might need to evaluate other data-fetching libraries such as react-query.

Or... we could fetch the remaining replies separately as a state for the Comment. Hmm...

Still... what kind of comment would get more than 100 replies anyway? 🤣
@laymonage laymonage added the bug Something isn't working label May 5, 2021
@laymonage laymonage mentioned this issue May 5, 2021
Closed
21 tasks
@laymonage laymonage changed the title Cannot show more than 100 replies Cannot show more than 100 replies to a single comment May 5, 2021
This was referenced Oct 2, 2021
Merged
Merged
@laymonage
Copy link
Member Author

With #184, at least now there's an indicator of the hidden replies and a direct link to the comment on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laymonage
0