8000 Accessibility considerations · Issue #1624 · giscus/giscus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Accessibility considerations #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jasonday opened this issue Mar 5, 2025 · 0 comments
Open

Accessibility considerations #1624

jasonday opened this issue Mar 5, 2025 · 0 comments

Comments

@jasonday
Copy link
jasonday commented Mar 5, 2025 •
edited
Loading

Non-exhaustive list (will add more as testing progresses):

  • Oldest/newest toggle utilizes aria-current which is not correct. On android talkback, the aria-current value is not conveyed
    • Use aria-pressed=[true/false"] on the buttons to get the correct behavior
  • non-logged in reaction buttons
    • I'm thinking through what's the best fix here.
    • One potential, just add line at the top that says you must be logged in to comment (with a link). Then don't update the reaction buttons aria-label - just leave them as disabled.
  • reaction buttons
    • use aria-pressed=[true/false] on all reaction buttons, so users know that they are toggle buttons
  • overall structure
    • Using a screen reader it can be hard to tell what the structure is. I think wrapping the top level comments/replies in a role="region" and aria-label=[commenter's id] would at least add some overall structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonday
0