8000 Undocumented breaking change · Issue #435 · geopy/geopy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Undocumented breaking change #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OrangeDog opened this issue Aug 20, 2020 · 3 comments
Closed

Undocumented breaking change #435

OrangeDog opened this issue Aug 20, 2020 · 3 comments
Labels
bug
Milesto 8000 ne
2.1

Comments

@OrangeDog
Copy link

The Distance class became abstract in 2.0, meaning it can no longer be used as a generic metric (e.g. for handling km and miles conversions).
@KostyaEsmukov KostyaEsmukov added this to the 2.1 milestone Aug 21, 2020
@KostyaEsmukov
Copy link
Member

Indeed, thanks for the report!

Technically the Distance class was never documented, so it wasn't considered as a part of the public API.

But given that this change was not documented, I'm going to remove the abstract class in the upcoming release 2.1.

For unit conversions there are functions exported by the geopy.units module, which are documented: https://geopy.readthedocs.io/en/stable/#module-geopy.units

@KostyaEsmukov
Copy link
Member

Fixed in ea9492c.

I'm still unsure though if we want to keep supporting the usage of Distance class just for unit conversions, so it might get deprecated in future.

@OrangeDog
Copy link
Author

TYVM. I find it convenient to have units attached to the quantity, instead of relying on people reading documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@OrangeDog @KostyaEsmukov
0