8000 Little Code Bugs · Issue #4 · gavinfay/cinar-mse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Little Code Bugs #4
Open
Open
@swulfing

Description

@swulfing

05/14 Fixing small things that didn't run due to R or package updates. Please let me know if there's a better way to format issues in github, this is my first one. I also stopped through day 3 and skipped the Multispecies MSE as it's less relevant to me right now but can do that a little down the road once my single species MSEs start looking good :)

  • 2.2 My first MSE practice Observe function (line 255 in /materials/exercises/day-01/my-first-mse.Rmd) needs to change from -0.5*sigma^2 to -0.5*sigma**2
  • 2.2 My first MSE practice Overshooting the TAC (a change to the TAC fxn made in line 511-515 of /materials/exercises/day-01/my-first-mse.Rmd) causes issues with adding new variables to functions as using the ellipse inside a function doesn't seem to work with this version of R anymore. I made the following changes so evaluate includes overshoot as a variable and it runs fine but not sure what you wanted to do with that
  1. Function "evaluate" on line 283-285 changed from
# evaluate <- function(pars.iter, biomass.iter,
#                      control.pars, data.years, proj.years,
#                      iterations, ...) {

To

evaluate <- function(pars.iter, biomass.iter,
  control.pars, data.years, proj.years,
  iterations, overshoot, ...) {
  1. Line 322 changed from catch.i[y] <- implement(TAC.i[y]) to catch.i[y] <- implement(TAC.i[y], overshoot)
  2. Lines 411, 501 call the function evaluate. These have similar fixes and have been changed from
evaluate(pars.iter, biomass.iter, control.pars, data.years,
                          proj.years, niter)

To

evaluate(pars.iter, biomass.iter, control.pars, data.years,
                          proj.years, niter, overshoot = NA)
  • 4.3 Additional Operating Model considerations Package furrr updated. line 23 in /materials/exercises/day-02/age-structure-om.Rmd needs to change from my_future_options <- future_options() to my_future_options <- furrr_options()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0