Breaking: Update for Node.js 10 support #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
May 13, 2020
* Enable parsing of ECMAScript 2018 syntax but forbid use by adding a eslint-plugin-node rule. * Permit use of ECMAScript 2018 global variables * Add common ignorePatterns into shared config * Declare override section for `test/**` to support mocha * Drop separate test.json published file * Declare support for node.js 10+
phated
approved these changes
May 13, 2020
| ], | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "dependencies": { | ||
| "eslint-config-prettier": "^6.11.0" | ||
| "eslint-config-prettier": "^6.11.0", | ||
| "eslint-plugin-node": "^11.1.0" |
There was a problem hiding this comment.
Ah, it's from a plugin! That makes sense.
| @@ -7,19 +7,19 @@ | |||
| "repository": "gulpjs/eslint-config-gulp", | |||
| "license": "MIT", | |||
| "engines": { | |||
| "node": ">= 0.10" | |||
| "node": ">=10" | |||
There was a problem hiding this comment.
I'll remove the space between >= and 10 in the boilerplate too when updating to 10.12 👍
|
Published. Thanks for the work here! 🍻 |
jimmywarting
reviewed
Dec 6, 2021
| }, | ||
| "rules": { | ||
| "node/no-unsupported-features/es-syntax": [2, {"version": ">=0.10"}], |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
@jimmywarting no this is by design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-node rule.
test/**to support mochaFixes #18