8000 Failing to extract license and copyright information from SVD files · Issue #933 · fsfe/reuse-tool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Failing to extract license and copyright information from SVD files #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rettichschnidi opened this issue Mar 20, 2024 · 2 comments
Open
Labels
enhancement New feature or request stale

Comments

@rettichschnidi
Copy link
rettichschnidi commented Mar 20, 2024

Problem

Reuse does detect neither the copyright (Copyright (c) 2010 - 2024, Nordic Semiconductor ASA All rights reserved.) nor the license (SPDX-License-Identifier: BSD-3-Clause) in nrf52840.svd.

It seems like the "\n" at the end of each line causes the problem. For files without those line endings, e.g. nrf5340_network.svd, the detection oft the license and copyright works.

Hints

According to the example given by ARM, the inventor of CMSIS-SVD, seems to be the (a) proper way to encode line breaks. For this reason, I think REUSE should support it.

Workarounds

  • Manually removing the "\n"
@rettichschnidi rettichschnidi changed the title Failing to extract license and copyright information from (certain) SVD files Failing to extract license and copyright information from SVD files Mar 20, 2024
@nicorikken nicorikken added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 13, 2024
@nicorikken
Copy link
Member

Thanks for reporting. Manual line endings in a file with line endings seems odd, but I can see how this ensures line endings are preserved.

An enhancement might be for all XML comment styles or even all files to handle these explicit '\n' line endings in addition to default line endings.

Copy link

Thank you for your time and contributions! Unfortunately, this issue has been inactive for quite a while which means we probably can't manage the time to deal with it. That's why we're marking it as stale. We want to keep things tidy and focus on active discussions, but we’re always happy to revisit if this is still relevant!

If you’d like to keep this open, please add a comment to let us know and remove the label stale. Otherwise, this issue will most likely be automatically closed soon.

@github-actions github-actions bot added the stale label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants
0