8000 Use non-multi-line comments when multi-line are not supported · Issue #914 · fsfe/reuse-tool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use non-multi-line comments when multi-line are not supported #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BigBlueHat opened this issue Feb 15, 2024 · 4 comments
Closed

Use non-multi-line comments when multi-line are not supported #914

BigBlueHat opened this issue Feb 15, 2024 · 4 comments
Labels
comment-styles Request for a new comment style, or fixing a bug with these enhancement New feature or request stale unresolved

Comments

@BigBlueHat
Copy link
Contributor

Currently an error is thrown...which stops all progress and means a different command must be used for various file extensions...which prevents use of --recursive:

reuse-tool/src/reuse/_annotate.py

Lines 77 to 83 in 00a8d94

if args.multi_line and not style.can_handle_multi():
args.parser.error(
_(
"'{path}' does not support multi-line comments, please"
" do not use --multi-line"
).format(path=path)
)

Given that non-multi-line files only support single line comments, there's no reason to stop the command completely. Instead, --multi-line could be described as "use multi-line comments when available".
@carmenbianca carmenbianca added enhancement New feature or request comment-styles Request for a new comment style, or fixing a bug with these labels Feb 16, 2024
@carmenbianca
Copy link
Member

This seems fair to me. Thank you for the feedback!

@carmenbianca carmenbianca mentioned this issue Feb 19, 2024
Closed
@BigBlueHat
Copy link
Contributor Author

I think it may also be good to make --multi-line the default once it doesn't fail on non-supporting filetypes (per thoughts in #916).

@github-actions GitHub Actions
Copy link

Thank you for your time and contributions! Unfortunately, this issue has been inactive for quite a while which means we probably can't manage the time to deal with it. That's why we're marking it as stale. We want to keep things tidy and focus on active discussions, but we’re always happy to revisit if this is still relevant!

If you’d like to keep this open, please add a comment to let us know and remove the label stale. Otherwise, this issue will most likely be automatically closed soon.

@github-actions github-actions bot added the stale label Apr 10, 2025
@github-actions GitHub Actions
Copy link

Since there hasn't been any recent activity after the last message, we're going to go ahead and close this issue. Feel free to reopen this and remove the labels stale and unresolved if it's urgent.

We truly appreciate your contributions and engagement!

Thank you and happy hacking!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comment-styles Request for a new comment style, or fixing a bug with these enhancement New feature or request stale unresolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BigBlueHat @carmenbianca
0